From 4dd25dda046a00feaec8ededefa97be8fa1ccbc1 Mon Sep 17 00:00:00 2001 From: Dylan Hurd Date: Mon, 16 Feb 2026 22:26:42 -0800 Subject: [PATCH] rm approval-presets --- codex-rs/Cargo.lock | 8 ---- codex-rs/Cargo.toml | 2 - codex-rs/tui/Cargo.toml | 1 - codex-rs/utils/approval-presets/BUILD.bazel | 6 --- codex-rs/utils/approval-presets/Cargo.toml | 11 ----- codex-rs/utils/approval-presets/src/lib.rs | 46 --------------------- 6 files changed, 74 deletions(-) delete mode 100644 codex-rs/utils/approval-presets/BUILD.bazel delete mode 100644 codex-rs/utils/approval-presets/Cargo.toml delete mode 100644 codex-rs/utils/approval-presets/src/lib.rs diff --git a/codex-rs/Cargo.lock b/codex-rs/Cargo.lock index 189d9468d2..4ee678c376 100644 --- a/codex-rs/Cargo.lock +++ b/codex-rs/Cargo.lock @@ -2290,7 +2290,6 @@ dependencies = [ "codex-protocol", "codex-state", "codex-utils-absolute-path", - "codex-utils-approval-presets", "codex-utils-cargo-bin", "codex-utils-cli", "codex-utils-elapsed", @@ -2364,13 +2363,6 @@ dependencies = [ "ts-rs", ] -[[package]] -name = "codex-utils-approval-presets" -version = "0.0.0" -dependencies = [ - "codex-core", -] - [[package]] name = "codex-utils-cache" version = "0.0.0" diff --git a/codex-rs/Cargo.toml b/codex-rs/Cargo.toml index 7ad0566efd..410a4e1e42 100644 --- a/codex-rs/Cargo.toml +++ b/codex-rs/Cargo.toml @@ -55,7 +55,6 @@ members = [ "utils/sandbox-summary", "utils/sanitizer", "utils/sleep-inhibitor", - "utils/approval-presets", "utils/oss", "utils/fuzzy-match", "codex-client", @@ -117,7 +116,6 @@ codex-state = { path = "state" } codex-stdio-to-uds = { path = "stdio-to-uds" } codex-tui = { path = "tui" } codex-utils-absolute-path = { path = "utils/absolute-path" } -codex-utils-approval-presets = { path = "utils/approval-presets" } codex-utils-cache = { path = "utils/cache" } codex-utils-cargo-bin = { path = "utils/cargo-bin" } codex-utils-cli = { path = "utils/cli" } diff --git a/codex-rs/tui/Cargo.toml b/codex-rs/tui/Cargo.toml index f791a3fc98..089d5eaabd 100644 --- a/codex-rs/tui/Cargo.toml +++ b/codex-rs/tui/Cargo.toml @@ -39,7 +39,6 @@ codex-login = { workspace = true } codex-otel = { workspace = true } codex-protocol = { workspace = true } codex-state = { workspace = true } -codex-utils-approval-presets = { workspace = true } codex-utils-absolute-path = { workspace = true } codex-utils-cli = { workspace = true } codex-utils-elapsed = { workspace = true } diff --git a/codex-rs/utils/approval-presets/BUILD.bazel b/codex-rs/utils/approval-presets/BUILD.bazel deleted file mode 100644 index 5fd4984486..0000000000 --- a/codex-rs/utils/approval-presets/BUILD.bazel +++ /dev/null @@ -1,6 +0,0 @@ -load("//:defs.bzl", "codex_rust_crate") - -codex_rust_crate( - name = "approval-presets", - crate_name = "codex_utils_approval_presets", -) diff --git a/codex-rs/utils/approval-presets/Cargo.toml b/codex-rs/utils/approval-presets/Cargo.toml deleted file mode 100644 index 1237545cd6..0000000000 --- a/codex-rs/utils/approval-presets/Cargo.toml +++ /dev/null @@ -1,11 +0,0 @@ -[package] -name = "codex-utils-approval-presets" -version.workspace = true -edition.workspace = true -license.workspace = true - -[lints] -workspace = true - -[dependencies] -codex-core = { workspace = true } diff --git a/codex-rs/utils/approval-presets/src/lib.rs b/codex-rs/utils/approval-presets/src/lib.rs deleted file mode 100644 index 9e66e39e08..0000000000 --- a/codex-rs/utils/approval-presets/src/lib.rs +++ /dev/null @@ -1,46 +0,0 @@ -use codex_core::protocol::AskForApproval; -use codex_core::protocol::SandboxPolicy; - -/// A simple preset pairing an approval policy with a sandbox policy. -#[derive(Debug, Clone)] -pub struct ApprovalPreset { - /// Stable identifier for the preset. - pub id: &'static str, - /// Display label shown in UIs. - pub label: &'static str, - /// Short human description shown next to the label in UIs. - pub description: &'static str, - /// Approval policy to apply. - pub approval: AskForApproval, - /// Sandbox policy to apply. - pub sandbox: SandboxPolicy, -} - -/// Built-in list of approval presets that pair approval and sandbox policy. -/// -/// Keep this UI-agnostic so it can be reused by both TUI and MCP server. -pub fn builtin_approval_presets() -> Vec { - vec![ - ApprovalPreset { - id: "read-only", - label: "Read Only", - description: "Codex can read files in the current workspace. Approval is required to edit files or access the internet.", - approval: AskForApproval::OnRequest, - sandbox: SandboxPolicy::new_read_only_policy(), - }, - ApprovalPreset { - id: "auto", - label: "Default", - description: "Codex can read and edit files in the current workspace, and run commands. Approval is required to access the internet or edit other files. (Identical to Agent mode)", - approval: AskForApproval::OnRequest, - sandbox: SandboxPolicy::new_workspace_write_policy(), - }, - ApprovalPreset { - id: "full-access", - label: "Full Access", - description: "Codex can edit files outside this workspace and access the internet without asking for approval. Exercise caution when using.", - approval: AskForApproval::Never, - sandbox: SandboxPolicy::DangerFullAccess, - }, - ] -}