From 4bd85ecf46edca371393f97e724884f9ca556bf9 Mon Sep 17 00:00:00 2001 From: Roy Han Date: Wed, 18 Mar 2026 18:31:13 -0700 Subject: [PATCH] inline policy --- codex-rs/core/src/codex_tests.rs | 5 ++++- codex-rs/core/src/state/turn.rs | 7 ------- .../core/src/tools/runtimes/shell/unix_escalation.rs | 10 ++++++++-- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/codex-rs/core/src/codex_tests.rs b/codex-rs/core/src/codex_tests.rs index 992e5c07da..0acf8fcbe9 100644 --- a/codex-rs/core/src/codex_tests.rs +++ b/codex-rs/core/src/codex_tests.rs @@ -4638,7 +4638,10 @@ async fn tool_call_metadata_stamps_policy_source_without_review_decision_when_fe sess.record_call_approval_outcome( "call-policy-runtime-1".to_string(), - ApprovalOutcomeMetadata::policy(), + ApprovalOutcomeMetadata { + review_decision: None, + approval_source: codex_protocol::models::ApprovalSourceMetadata::Policy, + }, ) .await; sess.record_response_item_and_emit_turn_item( diff --git a/codex-rs/core/src/state/turn.rs b/codex-rs/core/src/state/turn.rs index bdb79c4ba3..b39b1b1ca8 100644 --- a/codex-rs/core/src/state/turn.rs +++ b/codex-rs/core/src/state/turn.rs @@ -107,13 +107,6 @@ impl ApprovalOutcomeMetadata { approval_source, } } - - pub(crate) fn policy() -> Self { - Self { - review_decision: None, - approval_source: ApprovalSourceMetadata::Policy, - } - } } impl ActiveTurn { diff --git a/codex-rs/core/src/tools/runtimes/shell/unix_escalation.rs b/codex-rs/core/src/tools/runtimes/shell/unix_escalation.rs index db1de9a596..0e171ae830 100644 --- a/codex-rs/core/src/tools/runtimes/shell/unix_escalation.rs +++ b/codex-rs/core/src/tools/runtimes/shell/unix_escalation.rs @@ -535,7 +535,10 @@ impl CoreShellActionProvider { self.session .record_call_approval_outcome( self.call_id.clone(), - ApprovalOutcomeMetadata::policy(), + ApprovalOutcomeMetadata { + review_decision: None, + approval_source: ApprovalSourceMetadata::Policy, + }, ) .await; EscalationDecision::deny(Some("Execution forbidden by policy".to_string())) @@ -547,7 +550,10 @@ impl CoreShellActionProvider { self.session .record_call_approval_outcome( self.call_id.clone(), - ApprovalOutcomeMetadata::policy(), + ApprovalOutcomeMetadata { + review_decision: None, + approval_source: ApprovalSourceMetadata::Policy, + }, ) .await; EscalationDecision::deny(Some("Execution forbidden by policy".to_string()))