Expose prompt hooks to clients

This commit is contained in:
Abhinav Vedmala
2026-07-09 18:35:42 -07:00
parent 9d14b483ec
commit 4bd15dec58
15 changed files with 369 additions and 32 deletions
@@ -1,4 +1,5 @@
use codex_app_server_protocol::HookEventName;
use codex_app_server_protocol::HookHandlerType;
use codex_app_server_protocol::HookMetadata;
use codex_app_server_protocol::HookSource;
use codex_app_server_protocol::HookTrustStatus;
@@ -38,7 +39,7 @@ use crate::style::accent_style;
const EVENT_COLUMN_WIDTH: usize = 22;
const COUNT_COLUMN_WIDTH: usize = 12;
const MAX_COMMAND_DETAIL_LINES: usize = 3;
const MAX_HANDLER_DEFINITION_DETAIL_LINES: usize = 3;
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum HooksBrowserPage {
@@ -485,12 +486,27 @@ impl HooksBrowserView {
width,
/*max_lines*/ None,
));
let (definition_label, definition) = hook_definition(hook);
lines.extend(detail_wrapped_lines(
"Command",
hook.command.as_deref().unwrap_or("-"),
definition_label,
definition,
width,
Some(MAX_COMMAND_DETAIL_LINES),
Some(MAX_HANDLER_DEFINITION_DETAIL_LINES),
));
if hook.handler_type == HookHandlerType::Prompt {
lines.push(detail_line(
"Model",
hook.model.as_deref().unwrap_or("default"),
));
lines.push(detail_line(
"On block",
if hook.continue_on_block.unwrap_or(false) {
"continue"
} else {
"stop"
},
));
}
lines.push(detail_line("Timeout", &format!("{}s", hook.timeout_sec)));
lines.push(detail_line("Trust", hook_trust_label(hook.trust_status)));
lines
@@ -727,6 +743,14 @@ fn hook_trust_label(status: HookTrustStatus) -> &'static str {
}
}
fn hook_definition(hook: &HookMetadata) -> (&'static str, &str) {
match hook.handler_type {
HookHandlerType::Command => ("Command", hook.command.as_deref().unwrap_or("-")),
HookHandlerType::Prompt => ("Prompt", hook.prompt.as_deref().unwrap_or("-")),
HookHandlerType::Agent => ("Agent", "-"),
}
}
fn event_label(event_name: HookEventName) -> &'static str {
match event_name {
HookEventName::PreToolUse => "PreToolUse",
@@ -932,6 +956,9 @@ mod tests {
is_managed,
matcher: Some("Bash".to_string()),
command: Some(command.to_string()),
prompt: None,
model: None,
continue_on_block: None,
timeout_sec: 30,
status_message: None,
source_path: test_path_buf("/tmp/hooks.json").abs(),
@@ -1267,6 +1294,41 @@ mod tests {
);
}
#[test]
fn renders_prompt_hook_definition() {
let (tx_raw, _rx) = unbounded_channel::<AppEvent>();
let mut prompt_hook = hook(
"path:prompt-hook",
HookEventName::PostToolUse,
HookSource::User,
/*plugin_id*/ None,
/*command*/ "",
/*enabled*/ true,
/*is_managed*/ false,
/*display_order*/ 0,
);
prompt_hook.handler_type = HookHandlerType::Prompt;
prompt_hook.command = None;
prompt_hook.prompt = Some("Reject prompts that mention secrets: $ARGUMENTS".to_string());
prompt_hook.model = Some("gpt-5.1".to_string());
prompt_hook.continue_on_block = Some(true);
let mut view = HooksBrowserView::new(
vec![prompt_hook],
Vec::new(),
Vec::new(),
AppEventSender::new(tx_raw),
);
view.state.selected_idx = view
.event_rows()
.iter()
.position(|row| row.event_name == HookEventName::PostToolUse);
view.handle_key_event(KeyEvent::from(KeyCode::Enter));
assert_snapshot!(
"hooks_browser_prompt_hook_definition",
render_lines(&view, /*width*/ 112)
);
}
#[test]
fn renders_empty_handler_browser_message() {
let (tx_raw, _rx) = unbounded_channel::<AppEvent>();
@@ -0,0 +1,20 @@
---
source: tui/src/bottom_pane/hooks_browser_view.rs
expression: "render_lines(&view, 112)"
---
PostToolUse hooks
Turn hooks on or off. Your changes are saved automatically.
[x] Hook 1
Event PostToolUse
Matcher Bash
Source User config - /tmp/hooks.json
Prompt Reject prompts that mention secrets: $ARGUMENTS
Model gpt-5.1
On block continue
Timeout 30s
Trust Trusted
Press space or enter to toggle; esc to go back
+3
View File
@@ -309,6 +309,9 @@ mod tests {
is_managed: false,
matcher: Some("Bash".to_string()),
command: Some("/tmp/hook.sh".to_string()),
prompt: None,
model: None,
continue_on_block: None,
timeout_sec: 30,
status_message: None,
source_path: test_path_buf("/tmp/hooks.json").abs(),