mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
core: emit leftover user-message lifecycle
This commit is contained in:
@@ -1510,21 +1510,6 @@ impl ChatWidget {
|
||||
self.request_redraw();
|
||||
|
||||
let had_pending_steers = !self.pending_steers.is_empty();
|
||||
while let Some(pending_steer) = self.pending_steers.pop_front() {
|
||||
self.last_rendered_user_message_event = Some(pending_steer.clone());
|
||||
if !pending_steer.message.trim().is_empty()
|
||||
|| !pending_steer.text_elements.is_empty()
|
||||
|| !pending_steer.remote_image_urls.is_empty()
|
||||
{
|
||||
self.add_to_history(history_cell::new_user_prompt(
|
||||
pending_steer.message,
|
||||
pending_steer.text_elements,
|
||||
pending_steer.local_images,
|
||||
pending_steer.remote_image_urls,
|
||||
));
|
||||
}
|
||||
self.needs_final_message_separator = false;
|
||||
}
|
||||
self.refresh_pending_input_preview();
|
||||
|
||||
if !from_replay && self.queued_user_messages.is_empty() && !had_pending_steers {
|
||||
|
||||
@@ -3973,30 +3973,6 @@ queued draft"
|
||||
assert_no_submit_op(&mut op_rx);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn task_complete_renders_unacknowledged_pending_steer() {
|
||||
let (mut chat, mut rx, mut op_rx) = make_chatwidget_manual(None).await;
|
||||
chat.thread_id = Some(ThreadId::new());
|
||||
chat.on_task_started();
|
||||
|
||||
chat.bottom_pane
|
||||
.set_composer_text("late steer".to_string(), Vec::new(), Vec::new());
|
||||
chat.handle_key_event(KeyEvent::new(KeyCode::Enter, KeyModifiers::NONE));
|
||||
|
||||
match next_submit_op(&mut op_rx) {
|
||||
Op::UserTurn { .. } => {}
|
||||
other => panic!("expected Op::UserTurn, got {other:?}"),
|
||||
}
|
||||
assert!(drain_insert_history(&mut rx).is_empty());
|
||||
|
||||
chat.on_task_complete(None, false);
|
||||
|
||||
assert!(chat.pending_steers.is_empty());
|
||||
let inserted = drain_insert_history(&mut rx);
|
||||
assert_eq!(inserted.len(), 1);
|
||||
assert!(lines_to_single_string(&inserted[0]).contains("late steer"));
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn enter_submits_when_plan_stream_is_not_active() {
|
||||
let (mut chat, _rx, mut op_rx) = make_chatwidget_manual(None).await;
|
||||
|
||||
Reference in New Issue
Block a user