mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Remove fixed message-board views and bulk subscriptions (#62137)
## Why Guardian v3 reviewers can retrieve evidence from the live board, including posts that arrive after a review begins. Fixed board views and bulk subscription updates have no remaining callers outside tests. https://github.com/openai/codex/commit/c2595ad3438311ce3070b1a7eef05cd0da8ad631 ## What changed Remove `BoardReadView`, its snapshot-specific tool bindings, and the captured catalog and post cutoff from local board queries. Remove `set_subscriptions` and keep individual subscription changes through `set_subscription`. Update the Guardian housekeeping test to check channel descriptions through `list_channels`, and store captured Guardian evidence in an owned vector. GitOrigin-RevId: ede9e48abf4d009a2b4a82a437851657e41cf009
This commit is contained in:
@@ -20,7 +20,6 @@ use codex_thread_store::ThreadStoreResult;
|
||||
use codex_utils_string::to_json_string_bounded;
|
||||
use serde::Deserialize;
|
||||
use serde::Serialize;
|
||||
use std::sync::Arc;
|
||||
|
||||
/// Position in the containing snapshot's root history, independent of channel routing.
|
||||
#[derive(Clone, Copy, Debug, Deserialize, Eq, PartialEq, Serialize)]
|
||||
@@ -50,13 +49,11 @@ pub struct OriginalEvidence {
|
||||
}
|
||||
|
||||
/// An immutable capture. Later history appends cannot enter its reads or routing.
|
||||
/// Clones share the captured records rather than copying message payloads.
|
||||
#[derive(Clone)]
|
||||
pub struct EvidenceSnapshot {
|
||||
thread_id: ThreadId,
|
||||
start: HistoryPosition,
|
||||
end: HistoryPosition,
|
||||
records: Arc<[OriginalEvidence]>,
|
||||
records: Vec<OriginalEvidence>,
|
||||
// Report these positions only when the intake cursor accepts this capture.
|
||||
pub(super) skipped_incomplete_deliveries: Vec<u64>,
|
||||
}
|
||||
@@ -179,7 +176,7 @@ impl EvidenceCursor {
|
||||
thread_id: self.thread_id,
|
||||
start: self.position,
|
||||
end,
|
||||
records: records.into(),
|
||||
records,
|
||||
skipped_incomplete_deliveries,
|
||||
})
|
||||
}
|
||||
|
||||
@@ -463,9 +463,19 @@ async fn routes_captured_originals_and_updates_descriptions(
|
||||
json!({"catalog":catalog,"sources":[source]})
|
||||
);
|
||||
}
|
||||
let view = board.read_view(owner).await?;
|
||||
let release = view
|
||||
.channels()
|
||||
let catalog = board
|
||||
.list_channels(
|
||||
owner,
|
||||
ChannelQuery {
|
||||
query: Some("release".into()),
|
||||
direction: SortDirection::OldestFirst,
|
||||
page: PageRequest::default(),
|
||||
},
|
||||
)
|
||||
.await?;
|
||||
let release = catalog
|
||||
.channels
|
||||
.results
|
||||
.iter()
|
||||
.find(|channel| channel.channel_name == "release");
|
||||
assert_eq!(
|
||||
|
||||
Reference in New Issue
Block a user