From 42b5b37638de7a25bfc95ce9502c048b18e30a4a Mon Sep 17 00:00:00 2001 From: Dmitriy Kovalenko Date: Tue, 3 Nov 2026 20:35:57 +0000 Subject: [PATCH] Suppress macOS warnings in the V8 libc++ Bazel build (#59232) Add a macOS platform condition to apply `-Wno-pragma-clang-attribute` and `-Wno-thread-safety-analysis` when compiling V8's libc++ library. GitOrigin-RevId: daa5355a081e819818ada1f86833159cfa4cf555 --- third_party/v8/libcxx.BUILD.bazel | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/third_party/v8/libcxx.BUILD.bazel b/third_party/v8/libcxx.BUILD.bazel index 80af4d3674..82083c9eb1 100644 --- a/third_party/v8/libcxx.BUILD.bazel +++ b/third_party/v8/libcxx.BUILD.bazel @@ -8,6 +8,11 @@ config_setting( constraint_values = ["@platforms//os:linux"], ) +config_setting( + name = "is_macos", + constraint_values = ["@platforms//os:macos"], +) + config_setting( name = "is_windows", constraint_values = ["@platforms//os:windows"], @@ -129,6 +134,12 @@ libcxx_library( "@//third_party/v8:use_rusty_v8_custom_libcxx_native_windows": [], ":is_windows": ["-Wno-macro-redefined"], "//conditions:default": ["-fPIC"], + }) + select({ + ":is_macos": [ + "-Wno-pragma-clang-attribute", + "-Wno-thread-safety-analysis", + ], + "//conditions:default": [], }), defines = [ "CR_LIBCXX_REVISION=b16984ce99c702355a5b2b4c52574e82cec41fb9",