From 40bf387f73233c35678019467e1bfd63318888b8 Mon Sep 17 00:00:00 2001 From: Adam Syed Date: Wed, 6 May 2026 15:05:50 -0700 Subject: [PATCH] codex: fix CI failure on PR #21418 --- codex-rs/core/src/plugins/mentions_tests.rs | 31 +++++++++++++++------ codex-rs/core/src/plugins/render_tests.rs | 4 +-- 2 files changed, 24 insertions(+), 11 deletions(-) diff --git a/codex-rs/core/src/plugins/mentions_tests.rs b/codex-rs/core/src/plugins/mentions_tests.rs index e11eac9dd4..8e6ef6b954 100644 --- a/codex-rs/core/src/plugins/mentions_tests.rs +++ b/codex-rs/core/src/plugins/mentions_tests.rs @@ -109,7 +109,7 @@ fn collect_explicit_plugin_mentions_from_structured_paths() { mentioned, vec![explicit_plugin_mention( plugin("sample@test", "sample"), - false, + /*has_computer_use_native_fallback*/ false, )] ); } @@ -130,7 +130,7 @@ fn collect_explicit_plugin_mentions_from_linked_text_mentions() { mentioned, vec![explicit_plugin_mention( plugin("sample@test", "sample"), - false, + /*has_computer_use_native_fallback*/ false, )] ); } @@ -158,7 +158,7 @@ fn collect_explicit_plugin_mentions_dedupes_structured_and_linked_mentions() { mentioned, vec![explicit_plugin_mention( plugin("sample@test", "sample"), - false, + /*has_computer_use_native_fallback*/ false, )] ); } @@ -198,10 +198,15 @@ fn collect_explicit_plugin_mentions_marks_structured_native_fallbacks() { path: "plugin://zoom@test".to_string(), computer_use_native_app_bundle_id: Some("us.zoom.xos".to_string()), }], - &[zoom.clone()], + std::slice::from_ref(&zoom), ); - assert_eq!(mentioned, vec![explicit_plugin_mention(zoom, true)]); + assert_eq!( + mentioned, + vec![explicit_plugin_mention( + zoom, /*has_computer_use_native_fallback*/ true + )] + ); } #[test] @@ -221,8 +226,11 @@ fn collect_explicit_plugin_mentions_preserves_computer_use_context_for_native_fa assert_eq!( mentioned, vec![ - explicit_plugin_mention(zoom, true), - explicit_plugin_mention(computer_use, false), + explicit_plugin_mention(zoom, /*has_computer_use_native_fallback*/ true), + explicit_plugin_mention( + computer_use, + /*has_computer_use_native_fallback*/ false + ), ] ); } @@ -237,8 +245,13 @@ fn collect_explicit_plugin_mentions_ignores_empty_native_fallback_markers() { path: "plugin://zoom@test".to_string(), computer_use_native_app_bundle_id: Some(" ".to_string()), }], - &[zoom.clone()], + std::slice::from_ref(&zoom), ); - assert_eq!(mentioned, vec![explicit_plugin_mention(zoom, false)]); + assert_eq!( + mentioned, + vec![explicit_plugin_mention( + zoom, /*has_computer_use_native_fallback*/ false + )] + ); } diff --git a/codex-rs/core/src/plugins/render_tests.rs b/codex-rs/core/src/plugins/render_tests.rs index f9fc00819e..f5076213e8 100644 --- a/codex-rs/core/src/plugins/render_tests.rs +++ b/codex-rs/core/src/plugins/render_tests.rs @@ -32,7 +32,7 @@ fn render_explicit_plugin_instructions_mentions_native_app_fallback() { }, &[], &[], - true, + /*has_computer_use_native_fallback*/ true, ) .expect("native app fallback should render instructions"); @@ -52,7 +52,7 @@ fn render_explicit_plugin_instructions_omits_native_app_fallback_without_deduped }, &[], &[], - false, + /*has_computer_use_native_fallback*/ false, ) .expect("skill guidance should still render instructions");