Accept environment requests at thread and turn settings boundaries (#51422)

## What changed

Add `TurnEnvironmentRequests` to carry environment requests together with their fallback working directory. Update thread settings overrides and active turn settings to accept requests, constructing `TurnEnvironmentSelection` values in the receiving thread before validation and runtime use.

Adapt app-server callers, reviewer settings, and existing tests to supply requests or explicitly convert runtime selections back into requests.

GitOrigin-RevId: 8028f804bebe3fde553f57bb450f6dca3970cc4a
This commit is contained in:
Adam Perry @ OpenAI
2026-10-06 17:11:07 +00:00
committed by copyberry
parent 2c3565ebd8
commit 404cd42aa5
74 changed files with 399 additions and 289 deletions
+9 -5
View File
@@ -51,6 +51,7 @@ use codex_protocol::protocol::ThreadSettingsOverrides;
use codex_protocol::protocol::ThreadSettingsSnapshot;
use codex_protocol::protocol::ThreadSource;
use codex_protocol::protocol::TokenUsageInfo;
use codex_protocol::protocol::TurnEnvironmentRequests;
use codex_protocol::protocol::TurnEnvironmentSelection;
use codex_protocol::protocol::TurnEnvironmentSelections;
use codex_protocol::protocol::W3cTraceContext;
@@ -149,7 +150,7 @@ impl ThreadConfigSnapshot {
pub struct CodexThreadSettingsOverrides {
/// Replaces the data captured by future turns. Omission preserves it.
pub turn_extension_init: Option<codex_extension_api::ExtensionDataInit>,
pub environments: Option<TurnEnvironmentSelections>,
pub environments: Option<TurnEnvironmentRequests>,
pub runtime_workspace_roots: Option<Vec<AbsolutePathBuf>>,
pub profile_workspace_roots: Option<Vec<ProfileWorkspaceRoot>>,
pub approval_policy: Option<AskForApproval>,
@@ -667,7 +668,7 @@ impl CodexThread {
&self,
overrides: CodexThreadSettingsOverrides,
) -> ConstraintResult<ThreadConfigSnapshot> {
let updates = Self::thread_settings_update(overrides);
let updates = self.thread_settings_update(overrides);
self.session.preview_settings(&updates).await
}
@@ -702,7 +703,7 @@ impl CodexThread {
&self,
settings: CodexThreadSettingsOverrides,
) -> ConstraintResult<()> {
let updates = Self::thread_settings_update(settings);
let updates = self.thread_settings_update(settings);
self.session.update_settings(updates).await.map(|_| ())
}
@@ -713,7 +714,10 @@ impl CodexThread {
self.session.checkpoint_thread_settings().await
}
fn thread_settings_update(overrides: CodexThreadSettingsOverrides) -> SessionSettingsUpdate {
fn thread_settings_update(
&self,
overrides: CodexThreadSettingsOverrides,
) -> SessionSettingsUpdate {
let CodexThreadSettingsOverrides {
turn_extension_init,
environments: environment_requests,
@@ -745,7 +749,7 @@ impl CodexThread {
approval_policy,
approvals_reviewer,
},
environments: environment_requests,
environments: environment_requests.map(TurnEnvironmentRequests::select),
runtime_workspace_roots,
profile_workspace_roots,
sandbox_policy,