mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
Add configurable memory versions with isolated storage (#43797)
## What changed - Add `memories.version` with `v1` as the default and `v2` as an opt-in selection. - Route memory generation, summaries, and retrieval tools through the selected version. Store `v2` artifacts in `memories_v2` and lazily create a separate SQLite database, keeping jobs and outputs isolated while sharing the thread catalog. - Preserve the initial memory version across extension config updates so summaries and retrieval tools use the same namespace. - Clear both versions on memory reset and remove thread memory from both stores on thread deletion. Recognize both artifact roots in shell usage telemetry. ## Testing Add regression coverage for version defaults and validation, independent job claims and outputs, deletion and reset across versions, and shell usage classification for both memory roots. GitOrigin-RevId: aa799bf87ab6ec10c8f5668213931e57547d080b
This commit is contained in:
@@ -22,6 +22,7 @@ use codex_model_provider::SharedModelProvider;
|
||||
use codex_model_provider::create_model_provider;
|
||||
use codex_otel::SessionTelemetry;
|
||||
use codex_otel::TelemetryAuthMode;
|
||||
use codex_protocol::MemoryVersion;
|
||||
use codex_protocol::SessionId;
|
||||
use codex_protocol::ThreadId;
|
||||
use codex_protocol::config_types::ReasoningSummary;
|
||||
@@ -33,7 +34,7 @@ use codex_protocol::protocol::ThreadSource;
|
||||
use codex_protocol::protocol::TokenUsage;
|
||||
use codex_protocol::user_input::UserInput;
|
||||
use codex_rollout_trace::InferenceTraceContext;
|
||||
use codex_state::StateRuntime;
|
||||
use codex_state::MemoryStore;
|
||||
use codex_terminal_detection::user_agent;
|
||||
use futures::StreamExt;
|
||||
use std::sync::Arc;
|
||||
@@ -68,6 +69,7 @@ impl StageOneRequestContext {
|
||||
}
|
||||
|
||||
pub(crate) struct MemoryStartupContext {
|
||||
version: MemoryVersion,
|
||||
thread_id: ThreadId,
|
||||
thread: Arc<CodexThread>,
|
||||
thread_manager: Arc<ThreadManager>,
|
||||
@@ -173,6 +175,7 @@ impl MemoryStartupContext {
|
||||
);
|
||||
|
||||
Self {
|
||||
version: config.memories.version,
|
||||
thread_id,
|
||||
thread,
|
||||
thread_manager,
|
||||
@@ -186,8 +189,19 @@ impl MemoryStartupContext {
|
||||
self.thread_id
|
||||
}
|
||||
|
||||
pub(crate) fn state_db(&self) -> Option<Arc<StateRuntime>> {
|
||||
self.thread.state_db()
|
||||
pub(crate) async fn memory_store(&self) -> Option<MemoryStore> {
|
||||
match self
|
||||
.thread
|
||||
.state_db()?
|
||||
.memories_for_version(self.version)
|
||||
.await
|
||||
{
|
||||
Ok(store) => Some(store),
|
||||
Err(err) => {
|
||||
tracing::warn!("failed opening memory store: {err}");
|
||||
None
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
pub(crate) fn provider(&self) -> &dyn ModelProvider {
|
||||
|
||||
Reference in New Issue
Block a user