From 3e27195f2de00dc975b1db03440ade31b889d9b7 Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim Date: Thu, 24 Sep 2026 18:36:49 +0000 Subject: [PATCH] Parameterize the turn-start originator header test (#47918) Accept `service_name` and the expected originator as test parameters, passing `service_name` through `ThreadStartParams`. Retain the existing case that expects `TEST_ORIGINATOR` when no service name is provided. GitOrigin-RevId: 71097dcfe45496216cf3e765999ed0abd0a0cd71 --- codex-rs/app-server/tests/suite/v2/turn_start.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/codex-rs/app-server/tests/suite/v2/turn_start.rs b/codex-rs/app-server/tests/suite/v2/turn_start.rs index 57a0184665..13e5e96d6d 100644 --- a/codex-rs/app-server/tests/suite/v2/turn_start.rs +++ b/codex-rs/app-server/tests/suite/v2/turn_start.rs @@ -844,8 +844,12 @@ async fn turn_start_additional_context_flows_to_model_input() -> Result<()> { Ok(()) } +#[test_case::test_case(None, TEST_ORIGINATOR)] #[tokio::test] -async fn turn_start_sends_originator_header() -> Result<()> { +async fn turn_start_sends_originator_header( + service_name: Option<&str>, + expected_originator: &str, +) -> Result<()> { let responses = vec![create_final_assistant_message_sse_response("Done")?]; let server = create_mock_responses_server_sequence_unchecked(responses).await; @@ -870,6 +874,7 @@ async fn turn_start_sends_originator_header() -> Result<()> { .start_thread(ThreadStartParams { model: Some("mock-model".to_string()), thread_source: Some(ThreadSource::User), + service_name: service_name.map(str::to_string), ..Default::default() }) .await?; @@ -905,7 +910,7 @@ async fn turn_start_sends_originator_header() -> Result<()> { .headers .get("originator") .expect("originator header missing"); - assert_eq!(originator.to_str()?, TEST_ORIGINATOR); + assert_eq!(originator.to_str()?, expected_originator); } Ok(())