mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Stream partial thread search results and support cancellation (#62132)
## Why Clients using `thread/search` have to wait for the search to finish before they can show any matches. A search can also outlive the query that triggered it, such as when a user changes their task mention query. ## What changed - Add experimental `thread/search/stream` with best-effort `thread/search/partial` notifications. Each notification carries the original `requestId` and a batch of verified matches. Clients replace provisional matches with the final page, which determines results, ordering, and cursors. - Support connection-scoped cancellation through `thread/search/stream/cancel` and `thread/search/cancel` for their respective search methods. Disconnecting also stops active searches and reaps their search subprocesses. - Cancel superseded or timed-out TUI task mention searches without delaying available title matches. ## Testing Add coverage for incremental results and final-page parity, slow clients, connection-scoped cancellation and subprocess cleanup, and TUI task search cancellation. GitOrigin-RevId: b58abf7a1df424f191c8ede806d1d5266d299548
This commit is contained in:
committed by
copyberry
parent
c90234de95
commit
3bf4e138fe
@@ -77,6 +77,7 @@ from .v2_all import ThreadRealtimeStartedNotification
|
||||
from .v2_all import ThreadRealtimeTranscriptDeltaNotification
|
||||
from .v2_all import ThreadRealtimeTranscriptDoneNotification
|
||||
from .v2_all import ThreadRevertedNotification
|
||||
from .v2_all import ThreadSearchPartialNotification
|
||||
from .v2_all import ThreadSectionChangedNotification
|
||||
from .v2_all import ThreadSettingsUpdatedNotification
|
||||
from .v2_all import ThreadStartedNotification
|
||||
@@ -163,6 +164,7 @@ KnownNotificationPayload: TypeAlias = (
|
||||
| ThreadRealtimeTranscriptDeltaNotification
|
||||
| ThreadRealtimeTranscriptDoneNotification
|
||||
| ThreadRevertedNotification
|
||||
| ThreadSearchPartialNotification
|
||||
| ThreadSectionChangedNotification
|
||||
| ThreadSettingsUpdatedNotification
|
||||
| ThreadStartedNotification
|
||||
@@ -252,6 +254,7 @@ NOTIFICATION_MODELS: dict[str, type[KnownNotificationPayload]] = {
|
||||
"thread/realtime/transcript/delta": ThreadRealtimeTranscriptDeltaNotification,
|
||||
"thread/realtime/transcript/done": ThreadRealtimeTranscriptDoneNotification,
|
||||
"thread/reverted": ThreadRevertedNotification,
|
||||
"thread/search/partial": ThreadSearchPartialNotification,
|
||||
"thread/section/changed": ThreadSectionChangedNotification,
|
||||
"thread/settings/updated": ThreadSettingsUpdatedNotification,
|
||||
"thread/started": ThreadStartedNotification,
|
||||
|
||||
@@ -14413,6 +14413,31 @@ class ItemAutoApprovalReviewCompletedServerNotification(BaseModel):
|
||||
params: ItemGuardianApprovalReviewCompletedNotification
|
||||
|
||||
|
||||
class ThreadSearchPartialNotification(BaseModel):
|
||||
model_config = ConfigDict(
|
||||
populate_by_name=True,
|
||||
)
|
||||
data: list[ThreadSearchResult]
|
||||
request_id: Annotated[RequestId, Field(alias="requestId")]
|
||||
|
||||
|
||||
class ThreadSearchPartialServerNotification(BaseModel):
|
||||
model_config = ConfigDict(
|
||||
populate_by_name=True,
|
||||
)
|
||||
emitted_at_ms: Annotated[
|
||||
int | None,
|
||||
Field(
|
||||
alias="emittedAtMs",
|
||||
description="Unix timestamp (in milliseconds) when app-server emitted this notification.",
|
||||
),
|
||||
] = None
|
||||
method: Annotated[
|
||||
Literal["thread/search/partial"], Field(title="Thread/search/partialNotificationMethod")
|
||||
]
|
||||
params: ThreadSearchPartialNotification
|
||||
|
||||
|
||||
class ServerNotification(
|
||||
RootModel[
|
||||
ErrorServerNotification
|
||||
@@ -14453,6 +14478,7 @@ class ServerNotification(
|
||||
| ItemPlanDeltaServerNotification
|
||||
| CommandExecOutputDeltaServerNotification
|
||||
| ProcessOutputDeltaServerNotification
|
||||
| ThreadSearchPartialServerNotification
|
||||
| ProcessExitedServerNotification
|
||||
| ItemCommandExecutionOutputDeltaServerNotification
|
||||
| ItemCommandExecutionTerminalInteractionServerNotification
|
||||
@@ -14542,6 +14568,7 @@ class ServerNotification(
|
||||
| ItemPlanDeltaServerNotification
|
||||
| CommandExecOutputDeltaServerNotification
|
||||
| ProcessOutputDeltaServerNotification
|
||||
| ThreadSearchPartialServerNotification
|
||||
| ProcessExitedServerNotification
|
||||
| ItemCommandExecutionOutputDeltaServerNotification
|
||||
| ItemCommandExecutionTerminalInteractionServerNotification
|
||||
|
||||
Reference in New Issue
Block a user