mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Stream partial thread search results and support cancellation (#62132)
## Why Clients using `thread/search` have to wait for the search to finish before they can show any matches. A search can also outlive the query that triggered it, such as when a user changes their task mention query. ## What changed - Add experimental `thread/search/stream` with best-effort `thread/search/partial` notifications. Each notification carries the original `requestId` and a batch of verified matches. Clients replace provisional matches with the final page, which determines results, ordering, and cursors. - Support connection-scoped cancellation through `thread/search/stream/cancel` and `thread/search/cancel` for their respective search methods. Disconnecting also stops active searches and reaps their search subprocesses. - Cancel superseded or timed-out TUI task mention searches without delaying available title matches. ## Testing Add coverage for incremental results and final-page parity, slow clients, connection-scoped cancellation and subprocess cleanup, and TUI task search cancellation. GitOrigin-RevId: b58abf7a1df424f191c8ede806d1d5266d299548
This commit is contained in:
committed by
copyberry
parent
c90234de95
commit
3bf4e138fe
@@ -410,13 +410,15 @@ impl InProcessAppServerClient {
|
||||
// this loop can keep draining runtime events
|
||||
// while the request is blocked on client input.
|
||||
tokio::spawn(async move {
|
||||
// Device ceremonies belong to the waiting UI. Preserve
|
||||
// its cancellation through this buffering task.
|
||||
// Dropping the UI's request must drop the detached runtime
|
||||
// future too: its drop guard cancels verification and search.
|
||||
let cancellable = matches!(*request,
|
||||
ClientRequest::UserVerificationStatus { .. }
|
||||
| ClientRequest::UserVerificationEnroll { .. }
|
||||
| ClientRequest::UserVerificationDelete { .. }
|
||||
| ClientRequest::UserVerificationVerify { .. });
|
||||
| ClientRequest::UserVerificationVerify { .. }
|
||||
| ClientRequest::ThreadSearch { .. }
|
||||
| ClientRequest::ThreadSearchStream { .. });
|
||||
let mut response_tx = response_tx;
|
||||
tokio::select! {
|
||||
_ = response_tx.closed(), if cancellable => {}
|
||||
|
||||
Reference in New Issue
Block a user