From 38e0a598149b3e55a43092b5748f489b00a66cc0 Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim Date: Thu, 28 May 2026 12:57:09 -0700 Subject: [PATCH] Fix timing analytics assertion compilation --- codex-rs/app-server/tests/suite/v2/analytics.rs | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/codex-rs/app-server/tests/suite/v2/analytics.rs b/codex-rs/app-server/tests/suite/v2/analytics.rs index c272b70960..fe68498c39 100644 --- a/codex-rs/app-server/tests/suite/v2/analytics.rs +++ b/codex-rs/app-server/tests/suite/v2/analytics.rs @@ -190,17 +190,18 @@ pub(crate) fn assert_thread_initialization_timing_event( thread_id: &str, initialization_mode: &str, ) { + let durations_are_numbers = [ + "duration_ms", + "prepare_duration_ms", + "spawn_duration_ms", + "finalize_duration_ms", + ] + .map(|field| event["event_params"][field].as_u64().is_some()); assert_eq!( serde_json::json!({ "thread_id": event["event_params"]["thread_id"], "initialization_mode": event["event_params"]["initialization_mode"], - "durations_are_numbers": [ - "duration_ms", - "prepare_duration_ms", - "spawn_duration_ms", - "finalize_duration_ms", - ] - .map(|field| event["event_params"][field].as_u64().is_some()), + "durations_are_numbers": durations_are_numbers, }), serde_json::json!({ "thread_id": thread_id,