From 348ee26279c0538a3fb3bb308bbf71ef6d4bf8a1 Mon Sep 17 00:00:00 2001 From: Charles Cunningham Date: Tue, 24 Mar 2026 14:00:07 -0700 Subject: [PATCH] Clarify guardian timeout decision mapping Co-authored-by: Codex --- codex-rs/core/src/guardian/review.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/codex-rs/core/src/guardian/review.rs b/codex-rs/core/src/guardian/review.rs index 243059634d..d02223116d 100644 --- a/codex-rs/core/src/guardian/review.rs +++ b/codex-rs/core/src/guardian/review.rs @@ -50,6 +50,9 @@ pub(crate) enum GuardianApprovalDecision { } impl GuardianApprovalDecision { + // ReviewDecision is the generic approval-response type shared across user + // and guardian review flows. It does not have a dedicated timeout variant, + // so guardian timeouts fail closed when projected into that broader type. pub(crate) fn into_review_decision(self) -> codex_protocol::protocol::ReviewDecision { match self { Self::Approved => codex_protocol::protocol::ReviewDecision::Approved,