From 32b5f3406dbdd0504ffcafba820a7ca86f7f477e Mon Sep 17 00:00:00 2001 From: Charles Cunningham Date: Sun, 15 Feb 2026 15:28:19 -0800 Subject: [PATCH] Enable compaction tests and remove stale TODO markers --- codex-rs/core/tests/suite/compact.rs | 5 ----- codex-rs/core/tests/suite/compact_remote.rs | 5 ----- 2 files changed, 10 deletions(-) diff --git a/codex-rs/core/tests/suite/compact.rs b/codex-rs/core/tests/suite/compact.rs index ee77570414..b29ba0184a 100644 --- a/codex-rs/core/tests/suite/compact.rs +++ b/codex-rs/core/tests/suite/compact.rs @@ -2312,9 +2312,6 @@ async fn manual_compact_retries_after_context_window_error() { } #[tokio::test(flavor = "multi_thread", worker_threads = 2)] -// TODO(ccunningham): Re-enable after the follow-up compaction behavior PR lands. -// Current main behavior around non-context manual /compact failures is known-incorrect. -#[ignore = "behavior change covered in follow-up compaction PR"] async fn manual_compact_non_context_failure_retries_then_emits_task_error() { skip_if_no_network!(); @@ -3180,8 +3177,6 @@ async fn snapshot_request_shape_pre_turn_compaction_including_incoming_user_mess } #[tokio::test(flavor = "multi_thread", worker_threads = 2)] -// TODO(ccunningham): Update once pre-turn compaction context-overflow handling includes incoming -// user input and emits richer oversized-input messaging. async fn snapshot_request_shape_pre_turn_compaction_strips_incoming_model_switch() { skip_if_no_network!(); diff --git a/codex-rs/core/tests/suite/compact_remote.rs b/codex-rs/core/tests/suite/compact_remote.rs index 01e004b15d..e1c0af92ec 100644 --- a/codex-rs/core/tests/suite/compact_remote.rs +++ b/codex-rs/core/tests/suite/compact_remote.rs @@ -930,9 +930,6 @@ async fn remote_manual_compact_failure_emits_task_error_event() -> Result<()> { } #[tokio::test(flavor = "multi_thread", worker_threads = 2)] -// TODO(ccunningham): Re-enable after the follow-up compaction behavior PR lands. -// Current main behavior for rollout replacement-history persistence is known-incorrect. -#[ignore = "behavior change covered in follow-up compaction PR"] async fn remote_compact_persists_replacement_history_in_rollout() -> Result<()> { skip_if_no_network!(Ok(())); @@ -1542,8 +1539,6 @@ async fn snapshot_request_shape_remote_pre_turn_compaction_strips_incoming_model } #[tokio::test(flavor = "multi_thread", worker_threads = 2)] -// TODO(ccunningham): Update once remote pre-turn compaction context-overflow handling includes -// incoming user input and emits richer oversized-input messaging. async fn snapshot_request_shape_remote_pre_turn_compaction_context_window_exceeded() -> Result<()> { skip_if_no_network!(Ok(()));