From 3096a44711e8df38230278daa7f1c0c4cd93d1f4 Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Wed, 11 Feb 2026 09:30:38 -0800 Subject: [PATCH] feat: panic if Constrained does not support Disabled --- codex-rs/core/src/tasks/review.rs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/codex-rs/core/src/tasks/review.rs b/codex-rs/core/src/tasks/review.rs index daa394df91..111ff085ca 100644 --- a/codex-rs/core/src/tasks/review.rs +++ b/codex-rs/core/src/tasks/review.rs @@ -91,15 +91,7 @@ async fn start_review_conversation( .web_search_mode .set(WebSearchMode::Disabled) { - tracing::warn!( - "failed to force review web_search_mode=disabled; falling back to a normalizer: {err}" - ); - sub_agent_config.web_search_mode = - Constrained::normalized(WebSearchMode::Disabled, |_| WebSearchMode::Disabled) - .unwrap_or_else(|err| { - tracing::warn!("failed to build normalizer for review web_search_mode: {err}"); - Constrained::allow_any(WebSearchMode::Disabled) - }); + panic!("by construction Constrained must always support Disabled: {err}"); } // Set explicit review rubric for the sub-agent