From 2eebdf7f24ea06d5b23b719b9908f5cfa44cadc8 Mon Sep 17 00:00:00 2001 From: xli-oai Date: Fri, 29 May 2026 20:34:32 -0700 Subject: [PATCH] Clarify remote installed fallback error name --- codex-rs/core-plugins/src/remote.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/codex-rs/core-plugins/src/remote.rs b/codex-rs/core-plugins/src/remote.rs index de846aaf7e..f70b588c76 100644 --- a/codex-rs/core-plugins/src/remote.rs +++ b/codex-rs/core-plugins/src/remote.rs @@ -692,7 +692,7 @@ pub(crate) async fn fetch_remote_installed_plugins( let (global, workspace) = tokio::join!(global, workspace); let mut installed_plugins = Vec::new(); - let mut first_error = None; + let mut error_if_all_failed = None; let mut any_scope_succeeded = false; for (scope, result) in [ (RemotePluginScope::Global, global), @@ -714,13 +714,13 @@ pub(crate) async fn fetch_remote_installed_plugins( error = %err, "failed to fetch remote installed plugins for scope" ); - if first_error.is_none() { - first_error = Some(err); + if error_if_all_failed.is_none() { + error_if_all_failed = Some(err); } } } } - if !any_scope_succeeded && let Some(err) = first_error { + if !any_scope_succeeded && let Some(err) = error_if_all_failed { return Err(err); }