From 2cf65451e5ec1de88a0c64d44fc95c15dd9c8059 Mon Sep 17 00:00:00 2001 From: Eric Traut Date: Sun, 26 Apr 2026 21:20:14 -0700 Subject: [PATCH] codex: fix CI failure on PR #19755 --- codex-rs/codex-api/src/endpoint/responses.rs | 2 +- .../src/endpoint/responses_websocket.rs | 2 +- codex-rs/codex-api/src/stream_lifecycle.rs | 16 ++++++++++------ 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/codex-rs/codex-api/src/endpoint/responses.rs b/codex-rs/codex-api/src/endpoint/responses.rs index 6f39aa38f6..fb1d6096e3 100644 --- a/codex-rs/codex-api/src/endpoint/responses.rs +++ b/codex-rs/codex-api/src/endpoint/responses.rs @@ -72,7 +72,7 @@ impl ResponsesClient { request: ResponsesApiRequest, options: ResponsesOptions, ) -> Result { - self.stream_request_with_lifecycle(request, options, None) + self.stream_request_with_lifecycle(request, options, /*lifecycle*/ None) .await } diff --git a/codex-rs/codex-api/src/endpoint/responses_websocket.rs b/codex-rs/codex-api/src/endpoint/responses_websocket.rs index 448265c372..265f1d2710 100644 --- a/codex-rs/codex-api/src/endpoint/responses_websocket.rs +++ b/codex-rs/codex-api/src/endpoint/responses_websocket.rs @@ -219,7 +219,7 @@ impl ResponsesWebsocketConnection { request: ResponsesWsRequest, connection_reused: bool, ) -> Result { - self.stream_request_with_lifecycle(request, connection_reused, None) + self.stream_request_with_lifecycle(request, connection_reused, /*lifecycle*/ None) .await } diff --git a/codex-rs/codex-api/src/stream_lifecycle.rs b/codex-rs/codex-api/src/stream_lifecycle.rs index 6685132ddf..ca964fe03a 100644 --- a/codex-rs/codex-api/src/stream_lifecycle.rs +++ b/codex-rs/codex-api/src/stream_lifecycle.rs @@ -359,9 +359,11 @@ mod tests { #[test] fn records_response_ids_milestones_and_observed_kinds_in_order() { - let mut recorder = ResponseStreamLifecycleRecorder::new( - ResponseStreamLifecycleOptions::new(2, ResponseStreamTransport::ResponsesHttp), - ); + let mut recorder = + ResponseStreamLifecycleRecorder::new(ResponseStreamLifecycleOptions::new( + /*attempt*/ 2, + ResponseStreamTransport::ResponsesHttp, + )); for event in [ json!({"type": "response.created", "response": {"id": "resp-created"}}), @@ -403,9 +405,11 @@ mod tests { #[test] fn stream_errors_gain_diagnostic_context() { - let mut recorder = ResponseStreamLifecycleRecorder::new( - ResponseStreamLifecycleOptions::new(1, ResponseStreamTransport::ResponsesWebsocket), - ); + let mut recorder = + ResponseStreamLifecycleRecorder::new(ResponseStreamLifecycleOptions::new( + /*attempt*/ 1, + ResponseStreamTransport::ResponsesWebsocket, + )); let event: ResponsesStreamEvent = serde_json::from_value(json!({ "type": "response.output_item.added", "item": {"type": "message"}