mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Enable analytics by default for daemon-launched app servers (#49426)
## Why Daemon-launched app servers should use the same analytics default as first-party clients while honoring explicit user opt-outs. ## What changed Pass `--analytics-default-enabled` when the PID backend launches an app server, with or without remote control. Users can still disable analytics with `analytics.enabled = false` in `config.toml`. ## Testing Update argument assertions for both remote-control modes and the daemon start/restart test to expect the analytics flag alongside launch feature overrides. GitOrigin-RevId: 8a222a00fc56737f5fe2b0385abf59466d1a6671
This commit is contained in:
committed by
copyberry
parent
8ea2c0e0d4
commit
2cc65cdd4c
@@ -584,9 +584,9 @@ async fn daemon_start_and_restart_preserve_launch_features() {
|
||||
features
|
||||
);
|
||||
let expected = if features.is_empty() {
|
||||
"app-server\n--listen\nunix://\n--managed-daemon\n"
|
||||
"app-server\n--listen\nunix://\n--analytics-default-enabled\n--managed-daemon\n"
|
||||
} else {
|
||||
"app-server\n--listen\nunix://\n-c\nfeatures.api_key_model_discovery=true\n-c\nfeatures.code_mode_host=false\n--managed-daemon\n"
|
||||
"app-server\n--listen\nunix://\n--analytics-default-enabled\n-c\nfeatures.api_key_model_discovery=true\n-c\nfeatures.code_mode_host=false\n--managed-daemon\n"
|
||||
};
|
||||
assert_eq!(std::fs::read_to_string(&args_path).unwrap(), expected);
|
||||
let reused = daemon
|
||||
|
||||
Reference in New Issue
Block a user