From 29b362f80b16526c2ca80591aa93d4030304c6bf Mon Sep 17 00:00:00 2001 From: viyatb-oai Date: Wed, 10 Jun 2026 09:35:29 -0700 Subject: [PATCH] refactor(exec-server): validate Noise keys at use Co-authored-by: Codex --- codex-rs/exec-server/src/noise_channel.rs | 6 ------ codex-rs/exec-server/src/noise_channel_tests.rs | 3 ++- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/codex-rs/exec-server/src/noise_channel.rs b/codex-rs/exec-server/src/noise_channel.rs index f174808e4f..a389a9b23b 100644 --- a/codex-rs/exec-server/src/noise_channel.rs +++ b/codex-rs/exec-server/src/noise_channel.rs @@ -51,12 +51,6 @@ impl std::fmt::Debug for NoiseChannelPublicKey { } impl NoiseChannelPublicKey { - /// Validate suite selection, encoding, and exact key lengths. - pub fn validate(&self) -> Result<(), NoiseChannelError> { - let _ = self.decode()?; - Ok(()) - } - fn from_keypairs(dh: &DhKeyPair, kem: &KemKeyPair) -> Self { Self { suite: NOISE_CHANNEL_SUITE.to_string(), diff --git a/codex-rs/exec-server/src/noise_channel_tests.rs b/codex-rs/exec-server/src/noise_channel_tests.rs index 260d64c333..d44da88f6e 100644 --- a/codex-rs/exec-server/src/noise_channel_tests.rs +++ b/codex-rs/exec-server/src/noise_channel_tests.rs @@ -15,7 +15,8 @@ fn public_key_validation_rejects_unknown_suite() { let key: NoiseChannelPublicKey = serde_json::from_value(serde_json::Value::Object(object)).expect("deserialize key"); - assert!(key.validate().is_err()); + let initiator = NoiseChannelIdentity::generate().expect("generate initiator identity"); + assert!(InitiatorHandshake::start(&initiator, &key, b"prologue", b"").is_err()); } #[test]