mirror of
https://github.com/openai/codex.git
synced 2026-11-18 22:20:48 +00:00
Add strict automatic review for MCP elicitations (#36365)
## What changed - Recognize the `codex_strict_auto_review` MCP elicitation marker and route marked approval requests through the configured automatic reviewer. - Accept only canonical automatic-review approvals and fail closed without a user prompt when review is unavailable, denied, malformed, disallowed by policy, or requests persistence. - Validate Codex Apps approval metadata against the active MCP invocation and build the review request from the trusted invocation details. ## Testing - Add unit coverage for strict review decisions, malformed markers, reviewer failures, explicit policy denials, and lifecycle cleanup. - Add app-server round-trip coverage for approvals, denials, configuration constraints, spoofed metadata, persistent requests, and subsequent turns. GitOrigin-RevId: af73b45a9b63118f25f6429d95b3222c5dbb59fb
This commit is contained in:
@@ -391,7 +391,8 @@ async fn forward_events(
|
||||
// runtime after a refresh.
|
||||
let metadata = session
|
||||
.mcp_tool_approval_metadata(&id, &event.call_id)
|
||||
.await;
|
||||
.await
|
||||
.map(|(_, metadata)| metadata);
|
||||
pending_mcp_invocations
|
||||
.lock()
|
||||
.await
|
||||
|
||||
Reference in New Issue
Block a user