From 276c7fbb5d8ffddb0c05bd0f4c0fc5f4be3f9108 Mon Sep 17 00:00:00 2001
From: Owen Lin <owen@openai.com>
Date: Sat, 1 Nov 2025 10:50:37 -0700
Subject: [PATCH] also standardize method names to follow LSP order

---
 codex-rs/app-server-protocol/src/protocol/common.rs | 6 +++---
 codex-rs/app-server/src/codex_message_processor.rs  | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/codex-rs/app-server-protocol/src/protocol/common.rs b/codex-rs/app-server-protocol/src/protocol/common.rs
index 4810275aea..0d7a1d5f5a 100644
--- a/codex-rs/app-server-protocol/src/protocol/common.rs
+++ b/codex-rs/app-server-protocol/src/protocol/common.rs
@@ -144,7 +144,7 @@ client_request_definitions! {
 
     #[serde(rename = "model/list")]
     #[ts(rename = "model/list")]
-    ListModels {
+    ModelList {
         params: v2::ModelListParams,
         response: v2::ModelListResponse,
     },
@@ -172,7 +172,7 @@ client_request_definitions! {
 
     #[serde(rename = "feedback/upload")]
     #[ts(rename = "feedback/upload")]
-    UploadFeedback {
+    FeedbackUpload {
         params: v2::FeedbackUploadParams,
         response: v2::FeedbackUploadResponse,
     },
@@ -729,7 +729,7 @@ mod tests {
 
     #[test]
     fn serialize_list_models() -> Result<()> {
-        let request = ClientRequest::ListModels {
+        let request = ClientRequest::ModelList {
             request_id: RequestId::Integer(6),
             params: v2::ModelListParams::default(),
         };
diff --git a/codex-rs/app-server/src/codex_message_processor.rs b/codex-rs/app-server/src/codex_message_processor.rs
index 6dd93711f5..3667bf6c76 100644
--- a/codex-rs/app-server/src/codex_message_processor.rs
+++ b/codex-rs/app-server/src/codex_message_processor.rs
@@ -186,7 +186,7 @@ impl CodexMessageProcessor {
             ClientRequest::ListConversations { request_id, params } => {
                 self.handle_list_conversations(request_id, params).await;
             }
-            ClientRequest::ListModels { request_id, params } => {
+            ClientRequest::ModelList { request_id, params } => {
                 self.list_models(request_id, params).await;
             }
             ClientRequest::LoginAccount {
@@ -288,7 +288,7 @@ impl CodexMessageProcessor {
             } => {
                 self.get_account_rate_limits(request_id).await;
             }
-            ClientRequest::UploadFeedback { request_id, params } => {
+            ClientRequest::FeedbackUpload { request_id, params } => {
                 self.upload_feedback(request_id, params).await;
             }
         }