mirror of
https://github.com/openai/codex.git
synced 2026-11-19 22:30:42 +00:00
Allow Bedrock Runtime selection during setup and login (#62222)
## Why The app server's Bedrock setup and login flows always selected Mantle. Clients using Bedrock Runtime had to configure that provider separately. ## What changed Accept an optional `providerId` in `account/bedrock/setup` for AWS profiles and environment credentials, and in `account/login/start` for Bedrock API keys and AWS access keys. Pass `"amazon-bedrock-runtime"` to select Runtime. Omit the field or pass `null` to keep the Mantle default. Save configuration for the selected provider and check that provider for an existing `aws.credential_export` before changing credential sources. ## Testing Extend app-server tests to cover Runtime setup with profiles and environment credentials, Runtime login with both key types, and Mantle fallback. Verify that environment setup selects the Runtime default model for a new thread and that a configured Runtime credential exporter blocks profile setup. GitOrigin-RevId: 6396b638208ab9b12f50f13f13bd517a919d0848
This commit is contained in:
@@ -3521,11 +3521,13 @@ mod tests {
|
||||
v2::LoginAccountParams::AmazonBedrock {
|
||||
api_key: "secret".to_string(),
|
||||
region: "us-west-2".to_string(),
|
||||
provider_id: None,
|
||||
},
|
||||
json!({
|
||||
"type": "amazonBedrock",
|
||||
"apiKey": "secret",
|
||||
"region": "us-west-2"
|
||||
"region": "us-west-2",
|
||||
"providerId": null
|
||||
}),
|
||||
),
|
||||
(
|
||||
@@ -3534,13 +3536,15 @@ mod tests {
|
||||
secret_access_key: "secret-access-key".to_string(),
|
||||
session_token: Some("session-token".to_string()),
|
||||
region: "us-west-2".to_string(),
|
||||
provider_id: Some(v2::BedrockProviderId::AmazonBedrockRuntime),
|
||||
},
|
||||
json!({
|
||||
"type": "amazonBedrockAccessKeys",
|
||||
"accessKeyId": "access-key-id",
|
||||
"secretAccessKey": "secret-access-key",
|
||||
"sessionToken": "session-token",
|
||||
"region": "us-west-2"
|
||||
"region": "us-west-2",
|
||||
"providerId": "amazon-bedrock-runtime"
|
||||
}),
|
||||
),
|
||||
] {
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
use super::BedrockProviderId;
|
||||
use super::ThreadUsage;
|
||||
use crate::JsonSchema;
|
||||
use crate::TS;
|
||||
@@ -117,7 +118,13 @@ pub enum LoginAccountParams {
|
||||
#[experimental("account/login/start.amazonBedrock")]
|
||||
#[serde(rename = "amazonBedrock", rename_all = "camelCase")]
|
||||
#[ts(rename = "amazonBedrock", rename_all = "camelCase")]
|
||||
AmazonBedrock { api_key: String, region: String },
|
||||
AmazonBedrock {
|
||||
api_key: String,
|
||||
region: String,
|
||||
/// Defaults to Amazon Bedrock Mantle when omitted.
|
||||
#[ts(optional = nullable)]
|
||||
provider_id: Option<BedrockProviderId>,
|
||||
},
|
||||
/// [UNSTABLE] Managed Amazon Bedrock AWS access key login is experimental.
|
||||
#[experimental("account/login/start.amazonBedrockAccessKeys")]
|
||||
#[serde(rename = "amazonBedrockAccessKeys", rename_all = "camelCase")]
|
||||
@@ -128,6 +135,9 @@ pub enum LoginAccountParams {
|
||||
#[ts(optional = nullable)]
|
||||
session_token: Option<String>,
|
||||
region: String,
|
||||
/// Defaults to Amazon Bedrock Mantle when omitted.
|
||||
#[ts(optional = nullable)]
|
||||
provider_id: Option<BedrockProviderId>,
|
||||
},
|
||||
}
|
||||
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
use super::BedrockProviderId;
|
||||
use crate::JsonSchema;
|
||||
use crate::TS;
|
||||
use serde::Deserialize;
|
||||
@@ -50,10 +51,21 @@ pub enum AwsCredentialType {
|
||||
pub enum BedrockSetupParams {
|
||||
#[serde(rename_all = "camelCase")]
|
||||
#[ts(rename_all = "camelCase")]
|
||||
Profile { profile: String, region: String },
|
||||
Profile {
|
||||
profile: String,
|
||||
region: String,
|
||||
/// Defaults to Amazon Bedrock Mantle when omitted.
|
||||
#[ts(optional = nullable)]
|
||||
provider_id: Option<BedrockProviderId>,
|
||||
},
|
||||
#[serde(rename_all = "camelCase")]
|
||||
#[ts(rename_all = "camelCase")]
|
||||
Environment { region: String },
|
||||
Environment {
|
||||
region: String,
|
||||
/// Defaults to Amazon Bedrock Mantle when omitted.
|
||||
#[ts(optional = nullable)]
|
||||
provider_id: Option<BedrockProviderId>,
|
||||
},
|
||||
}
|
||||
|
||||
#[derive(Serialize, Deserialize, Debug, Default, Clone, PartialEq, Eq, JsonSchema, TS)]
|
||||
|
||||
Reference in New Issue
Block a user