openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-26 18:38:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Register named exec environments for app-server threads

Browse Source 
Add execEnvironment register/list requests, thread start selection, and thread metadata plumbing so app-server threads can bind to a named exec-server environment.

Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
starr-openai
2026-04-13 19:33:56 -07:00
co-authored by Codex
parent 0c8f3173e4
commit 1cc9eb24ce
10 changed files with 422 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/core/src/agent/control.rs
+4 -1
View File
@@ -238,10 +238,13 @@ impl AgentControl {
/*metrics_service_name*/ None,
inherited_shell_snapshot,
inherited_exec_policy,
None,
)
.await?
}
(None, _) => state.spawn_new_thread(config, self.clone()).await?,
(None, _) => state
.spawn_new_thread(config, self.clone(), None)
.await?,
};
agent_metadata.agent_id = Some(new_thread.thread_id);
reservation.commit(agent_metadata.clone());
codex-rs/core/src/thread_manager.rs
+38 -1
View File
@@ -496,6 +496,28 @@ impl ThreadManager {
persist_extended_history: bool,
metrics_service_name: Option<String>,
parent_trace: Option<W3cTraceContext>,
) -> CodexResult<NewThread> {
Box::pin(self.start_thread_with_tools_service_name_and_environment_manager(
config,
initial_history,
dynamic_tools,
persist_extended_history,
metrics_service_name,
/*environment_manager_override*/ None,
parent_trace,
))
.await
}
pub async fn start_thread_with_tools_service_name_and_environment_manager(
&self,
config: Config,
initial_history: InitialHistory,
dynamic_tools: Vec<codex_protocol::dynamic_tools::DynamicToolSpec>,
persist_extended_history: bool,
metrics_service_name: Option<String>,
environment_manager_override: Option<Arc<EnvironmentManager>>,
parent_trace: Option<W3cTraceContext>,
) -> CodexResult<NewThread> {
Box::pin(self.state.spawn_thread(
config,
@@ -505,6 +527,7 @@ impl ThreadManager {
dynamic_tools,
persist_extended_history,
metrics_service_name,
environment_manager_override,
parent_trace,
/*user_shell_override*/ None,
))
@@ -545,6 +568,7 @@ impl ThreadManager {
Vec::new(),
persist_extended_history,
/*metrics_service_name*/ None,
/*environment_manager_override*/ None,
parent_trace,
/*user_shell_override*/ None,
))
@@ -564,6 +588,7 @@ impl ThreadManager {
Vec::new(),
/*persist_extended_history*/ false,
/*metrics_service_name*/ None,
/*environment_manager_override*/ None,
/*parent_trace*/ None,
/*user_shell_override*/ Some(user_shell_override),
))
@@ -586,6 +611,7 @@ impl ThreadManager {
Vec::new(),
/*persist_extended_history*/ false,
/*metrics_service_name*/ None,
/*environment_manager_override*/ None,
/*parent_trace*/ None,
/*user_shell_override*/ Some(user_shell_override),
))
@@ -694,6 +720,7 @@ impl ThreadManager {
Vec::new(),
persist_extended_history,
/*metrics_service_name*/ None,
/*environment_manager_override*/ None,
parent_trace,
/*user_shell_override*/ None,
))
@@ -760,6 +787,7 @@ impl ThreadManagerState {
&self,
config: Config,
agent_control: AgentControl,
environment_manager_override: Option<Arc<EnvironmentManager>>,
) -> CodexResult<NewThread> {
Box::pin(self.spawn_new_thread_with_source(
config,
@@ -769,6 +797,7 @@ impl ThreadManagerState {
/*metrics_service_name*/ None,
/*inherited_shell_snapshot*/ None,
/*inherited_exec_policy*/ None,
environment_manager_override,
))
.await
}
@@ -783,6 +812,7 @@ impl ThreadManagerState {
metrics_service_name: Option<String>,
inherited_shell_snapshot: Option<Arc<ShellSnapshot>>,
inherited_exec_policy: Option<Arc<crate::exec_policy::ExecPolicyManager>>,
environment_manager_override: Option<Arc<EnvironmentManager>>,
) -> CodexResult<NewThread> {
Box::pin(self.spawn_thread_with_source(
config,
@@ -795,6 +825,7 @@ impl ThreadManagerState {
metrics_service_name,
inherited_shell_snapshot,
inherited_exec_policy,
environment_manager_override,
/*parent_trace*/ None,
/*user_shell_override*/ None,
))
@@ -822,6 +853,7 @@ impl ThreadManagerState {
/*metrics_service_name*/ None,
inherited_shell_snapshot,
inherited_exec_policy,
/*environment_manager_override*/ None,
/*parent_trace*/ None,
/*user_shell_override*/ None,
))
@@ -850,6 +882,7 @@ impl ThreadManagerState {
/*metrics_service_name*/ None,
inherited_shell_snapshot,
inherited_exec_policy,
/*environment_manager_override*/ None,
/*parent_trace*/ None,
/*user_shell_override*/ None,
))
@@ -867,6 +900,7 @@ impl ThreadManagerState {
dynamic_tools: Vec<codex_protocol::dynamic_tools::DynamicToolSpec>,
persist_extended_history: bool,
metrics_service_name: Option<String>,
environment_manager_override: Option<Arc<EnvironmentManager>>,
parent_trace: Option<W3cTraceContext>,
user_shell_override: Option<crate::shell::Shell>,
) -> CodexResult<NewThread> {
@@ -881,6 +915,7 @@ impl ThreadManagerState {
metrics_service_name,
/*inherited_shell_snapshot*/ None,
/*inherited_exec_policy*/ None,
environment_manager_override,
parent_trace,
user_shell_override,
))
@@ -900,6 +935,7 @@ impl ThreadManagerState {
metrics_service_name: Option<String>,
inherited_shell_snapshot: Option<Arc<ShellSnapshot>>,
inherited_exec_policy: Option<Arc<crate::exec_policy::ExecPolicyManager>>,
environment_manager_override: Option<Arc<EnvironmentManager>>,
parent_trace: Option<W3cTraceContext>,
user_shell_override: Option<crate::shell::Shell>,
) -> CodexResult<NewThread> {
@@ -914,7 +950,8 @@ impl ThreadManagerState {
config,
auth_manager,
models_manager: Arc::clone(&self.models_manager),
environment_manager: Arc::clone(&self.environment_manager),
environment_manager: environment_manager_override
.unwrap_or_else(|| Arc::clone(&self.environment_manager)),
skills_manager: Arc::clone(&self.skills_manager),
plugins_manager: Arc::clone(&self.plugins_manager),
mcp_manager: Arc::clone(&self.mcp_manager),