openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-07 20:30:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support Windows registry overrides for requirements.toml (#55456)

Browse Source 
## What changed

Read `RequirementsPath` from the 64-bit registry view of `HKLM\SOFTWARE\Policies\OpenAI\Codex` to select the system requirements file on Windows. Require an absolute path and return an error for relative values. If the registry key or value cannot be read, retain the default `OpenAI\Codex\requirements.toml` location under ProgramData.

## Testing

Expand absolute-path validation tests to cover empty, drive-relative, and root-relative paths. Update the Windows default-directory test to remain independent of registry overrides.

GitOrigin-RevId: c31045d749e32cf266b389245ae4db2440156e8e
This commit is contained in:
johnl-oai
2026-10-20 04:49:25 +00:00
committed by copyberry
parent 8196bcdc18
commit 18795fc125
5 changed files with 27 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/config/src/loader/mod.rs
+14 -15
View File
@@ -814,6 +814,16 @@ fn windows_codex_system_dir() -> PathBuf {
#[cfg(windows)]
fn windows_system_requirements_toml_file() -> io::Result<AbsolutePathBuf> {
if let Ok(path) = winreg::RegKey::predef(winreg::enums::HKEY_LOCAL_MACHINE)
.open_subkey_with_flags(
r"SOFTWARE\Policies\OpenAI\Codex",
winreg::enums::KEY_READ | winreg::enums::KEY_WOW64_64KEY,
)
.and_then(|key| key.get_value::<std::ffi::OsString, _>("RequirementsPath"))
{
return AbsolutePathBuf::from_absolute_path_checked(path);
}
let requirements_toml_file = windows_codex_system_dir().join("requirements.toml");
AbsolutePathBuf::try_from(requirements_toml_file)
}
@@ -2006,24 +2016,13 @@ foo = "xyzzy"
#[cfg(windows)]
#[test]
fn windows_system_requirements_toml_file_uses_expected_suffix() {
fn windows_codex_system_dir_uses_expected_suffix() {
let expected = windows_program_data_dir_from_known_folder()
.unwrap_or_else(|_| PathBuf::from(DEFAULT_PROGRAM_DATA_DIR_WINDOWS))
.join("OpenAI")
.join("Codex")
.join("requirements.toml");
assert_eq!(
windows_system_requirements_toml_file()
.expect("requirements.toml path")
.as_path(),
expected.as_path()
);
assert!(
windows_system_requirements_toml_file()
.expect("requirements.toml path")
.as_path()
.ends_with(Path::new("OpenAI").join("Codex").join("requirements.toml"))
);
.join("Codex");
assert_eq!(windows_codex_system_dir(), expected);
assert!(windows_codex_system_dir().ends_with(Path::new("OpenAI").join("Codex")));
}
#[cfg(windows)]