From 17e2ecd6414e63d1d2bcdee7355b4f43f5d7ffd6 Mon Sep 17 00:00:00 2001 From: canvrno-oai Date: Fri, 17 Apr 2026 11:57:00 -0700 Subject: [PATCH] avoid parenthesized rendered link urls --- codex-rs/tui/src/markdown_render.rs | 3 +-- codex-rs/tui/src/markdown_render_tests.rs | 6 ++---- ...down_render_tests__markdown_render_complex_snapshot.snap | 6 +++--- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/codex-rs/tui/src/markdown_render.rs b/codex-rs/tui/src/markdown_render.rs index ae680f5db3..c7fdb6b1d3 100644 --- a/codex-rs/tui/src/markdown_render.rs +++ b/codex-rs/tui/src/markdown_render.rs @@ -596,9 +596,8 @@ where fn pop_link(&mut self) { if let Some(link) = self.link.take() { if link.show_destination { - self.push_span(" (".into()); + self.push_span(" - ".into()); self.push_span(Span::styled(link.destination, self.styles.link)); - self.push_span(")".into()); } else if let Some(local_target_display) = link.local_target_display { if self.pending_marker_line { self.push_line(Line::default()); diff --git a/codex-rs/tui/src/markdown_render_tests.rs b/codex-rs/tui/src/markdown_render_tests.rs index 850d343853..7351905bba 100644 --- a/codex-rs/tui/src/markdown_render_tests.rs +++ b/codex-rs/tui/src/markdown_render_tests.rs @@ -652,9 +652,8 @@ fn link() { let text = render_markdown_text("[Link](https://example.com)"); let expected = Text::from(Line::from_iter([ "Link".into(), - " (".into(), + " - ".into(), "https://example.com".cyan().underlined(), - ")".into(), ])); assert_eq!(text, expected); } @@ -807,9 +806,8 @@ fn url_link_shows_destination() { let text = render_markdown_text("[docs](https://example.com/docs)"); let expected = Text::from(Line::from_iter([ "docs".into(), - " (".into(), + " - ".into(), "https://example.com/docs".cyan().underlined(), - ")".into(), ])); assert_eq!(text, expected); } diff --git a/codex-rs/tui/src/snapshots/codex_tui__markdown_render__markdown_render_tests__markdown_render_complex_snapshot.snap b/codex-rs/tui/src/snapshots/codex_tui__markdown_render__markdown_render_tests__markdown_render_complex_snapshot.snap index cc752dd66d..eb96fa1720 100644 --- a/codex-rs/tui/src/snapshots/codex_tui__markdown_render__markdown_render_tests__markdown_render_complex_snapshot.snap +++ b/codex-rs/tui/src/snapshots/codex_tui__markdown_render__markdown_render_tests__markdown_render_complex_snapshot.snap @@ -6,8 +6,8 @@ expression: rendered Intro paragraph with bold text, italic text, and inline code x=1. Combined bold-italic both and escaped asterisks *literal*. -Auto-link: https://example.com (https://example.com) and reference link [ref][r1]. -Link with title: hover me (https://example.com) and mailto mailto:test@example.com (mailto:test@example.com). +Auto-link: https://example.com - https://example.com and reference link [ref][r1]. +Link with title: hover me - https://example.com and mailto mailto:test@example.com - mailto:test@example.com. Image: alt text > Blockquote level 1 @@ -23,7 +23,7 @@ Image: alt text 1. Alt-numbered subitem - [ ] Task: unchecked -- [x] Task: checked with link home (https://example.org) +- [x] Task: checked with link home - https://example.org ———