openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-20 17:38:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Filter graceful shutdown guard and trigger traces from SQLite logs (#49414)

Browse Source 
## What changed

Set the default SQLite log filter to `DEBUG` for `tokio_graceful::guard` and `tokio_graceful::trigger`, dropping their `TRACE` events while retaining debug and higher-level diagnostics.

## Testing

Extend the SQLite sink filter test to verify that guard and trigger traces are dropped, their debug events are retained, and `tokio_graceful::shutdown` trace events remain available.

GitOrigin-RevId: c98495c834db35f3d8799ab4f0a1f7a82a53c8ef
This commit is contained in:
Dmitriy Kovalenko
2026-09-30 00:50:50 +00:00
committed by copyberry
parent eefe0ce1a8
commit 16a7c0f0eb
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/state/src/log_db.rs
+2
View File
@@ -74,6 +74,8 @@ pub fn default_filter() -> Targets {
.with_target("codex_otel.log_only", LevelFilter::OFF)
.with_target("codex_otel.trace_safe", LevelFilter::OFF)
.with_target("rmcp", LevelFilter::INFO)
.with_target("tokio_graceful::guard", LevelFilter::DEBUG)
.with_target("tokio_graceful::trigger", LevelFilter::DEBUG)
.with_target("codex_api::responses_websocket_timing", LevelFilter::OFF)
.with_target("codex_core::post_sampling_token_estimate", LevelFilter::OFF)
// Full model request bodies and streamed response payloads overwhelm the
codex-rs/state/src/log_db_filter_tests.rs
+20
View File
@@ -49,6 +49,11 @@ async fn sqlite_sink_filters_noisy_targets_without_dropping_useful_diagnostics()
tracing::warn!(target: "h2::proto::streams", "retained-http2-warning");
tracing::debug!(target: "rmcp::transport", "dropped-rmcp-debug");
tracing::info!(target: "rmcp::transport", "retained-rmcp-info");
tracing::trace!(target: "tokio_graceful::guard", "dropped-guard-trace");
tracing::debug!(target: "tokio_graceful::guard", "retained-guard-debug");
tracing::trace!(target: "tokio_graceful::trigger", "dropped-trigger-trace");
tracing::debug!(target: "tokio_graceful::trigger", "retained-trigger-debug");
tracing::trace!(target: "tokio_graceful::shutdown", "retained-shutdown-trace");
tracing::debug!(
target: "codex_rmcp_client::oauth",
"dropped-codex-rmcp-client-debug"
@@ -118,6 +123,21 @@ async fn sqlite_sink_filters_noisy_targets_without_dropping_useful_diagnostics()
),
("WARN", "h2::proto::streams", Some("retained-http2-warning")),
("INFO", "rmcp::transport", Some("retained-rmcp-info")),
(
"DEBUG",
"tokio_graceful::guard",
Some("retained-guard-debug")
),
(
"DEBUG",
"tokio_graceful::trigger",
Some("retained-trigger-debug")
),
(
"TRACE",
"tokio_graceful::shutdown",
Some("retained-shutdown-trace")
),
(
"INFO",
"codex_rmcp_client::oauth",