mirror of
https://github.com/openai/codex.git
synced 2026-11-08 20:40:33 +00:00
make it better
This commit is contained in:
@@ -2699,14 +2699,11 @@ async fn spawn_review_thread(
|
||||
text_elements: Vec::new(),
|
||||
}];
|
||||
let tc = Arc::new(review_turn_context);
|
||||
sess.spawn_task(tc.clone(), input, ReviewTask::new()).await;
|
||||
|
||||
// Announce entering review mode so UIs can switch modes.
|
||||
let review_request = ReviewRequest {
|
||||
target: resolved.target,
|
||||
user_facing_hint: Some(resolved.user_facing_hint),
|
||||
};
|
||||
sess.send_event(&tc, EventMsg::EnteredReviewMode(review_request))
|
||||
sess.spawn_task(tc.clone(), input, ReviewTask::new(review_request))
|
||||
.await;
|
||||
}
|
||||
|
||||
@@ -4374,7 +4371,13 @@ mod tests {
|
||||
text: "start review".to_string(),
|
||||
text_elements: Vec::new(),
|
||||
}];
|
||||
sess.spawn_task(Arc::clone(&tc), input, ReviewTask::new())
|
||||
let review_request = ReviewRequest {
|
||||
target: codex_protocol::protocol::ReviewTarget::Custom {
|
||||
instructions: "start review".to_string(),
|
||||
},
|
||||
user_facing_hint: None,
|
||||
};
|
||||
sess.spawn_task(Arc::clone(&tc), input, ReviewTask::new(review_request))
|
||||
.await;
|
||||
|
||||
sess.abort_all_tasks(TurnAbortReason::Interrupted).await;
|
||||
|
||||
Reference in New Issue
Block a user