From 0e52975969ab92a8a9db6be0d9ed227be0d2eb5a Mon Sep 17 00:00:00 2001 From: Charles Cunningham Date: Fri, 6 Mar 2026 13:46:16 -0800 Subject: [PATCH] Enable default-mode request_user_input by default Promote DefaultModeRequestUserInput to stable and enable it by default. Update codex-core tool-spec tests to reflect the new default-on behavior while keeping coverage for explicitly disabling the feature. Co-authored-by: Codex --- codex-rs/core/src/features.rs | 4 ++-- codex-rs/core/src/tools/spec.rs | 14 ++++++++------ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/codex-rs/core/src/features.rs b/codex-rs/core/src/features.rs index 7defc571ff..362126b2e4 100644 --- a/codex-rs/core/src/features.rs +++ b/codex-rs/core/src/features.rs @@ -686,8 +686,8 @@ pub const FEATURES: &[FeatureSpec] = &[ FeatureSpec { id: Feature::DefaultModeRequestUserInput, key: "default_mode_request_user_input", - stage: Stage::UnderDevelopment, - default_enabled: false, + stage: Stage::Stable, + default_enabled: true, }, FeatureSpec { id: Feature::CollaborationModes, diff --git a/codex-rs/core/src/tools/spec.rs b/codex-rs/core/src/tools/spec.rs index f0c952e078..47250100cb 100644 --- a/codex-rs/core/src/tools/spec.rs +++ b/codex-rs/core/src/tools/spec.rs @@ -2262,7 +2262,9 @@ mod tests { create_exec_command_tool(true, false), create_write_stdin_tool(), PLAN_TOOL.clone(), - create_request_user_input_tool(CollaborationModesConfig::default()), + create_request_user_input_tool(CollaborationModesConfig { + default_mode_request_user_input: true, + }), create_apply_patch_freeform_tool(), ToolSpec::WebSearch { external_web_access: Some(true), @@ -2381,10 +2383,12 @@ mod tests { let request_user_input_tool = find_tool(&tools, "request_user_input"); assert_eq!( request_user_input_tool.spec, - create_request_user_input_tool(CollaborationModesConfig::default()) + create_request_user_input_tool(CollaborationModesConfig { + default_mode_request_user_input: true, + }) ); - features.enable(Feature::DefaultModeRequestUserInput); + features.disable(Feature::DefaultModeRequestUserInput); let tools_config = ToolsConfig::new(&ToolsConfigParams { model_info: &model_info, features: &features, @@ -2395,9 +2399,7 @@ mod tests { let request_user_input_tool = find_tool(&tools, "request_user_input"); assert_eq!( request_user_input_tool.spec, - create_request_user_input_tool(CollaborationModesConfig { - default_mode_request_user_input: true, - }) + create_request_user_input_tool(CollaborationModesConfig::default()) ); }