feat(tui) /permissions custom option

This commit is contained in:
Dylan Hurd
2026-02-13 15:27:19 -08:00
parent 8d97b5c246
commit 0ab58c871c
8 changed files with 183 additions and 65 deletions
+1 -1
View File
@@ -31,7 +31,7 @@ pub fn builtin_approval_presets() -> Vec<ApprovalPreset> {
ApprovalPreset {
id: "auto",
label: "Default",
description: "Codex can read and edit files in the current workspace, and run commands. Approval is required to access the internet or edit other files. (Identical to Agent mode)",
description: "Codex can read and edit files in the current workspace, and run commands. Approval is required to access the internet or edit other files.",
approval: AskForApproval::OnRequest,
sandbox: SandboxPolicy::new_workspace_write_policy(),
},
@@ -15,7 +15,7 @@ pub fn create_config_summary_entries(config: &Config, model: &str) -> Vec<(&'sta
),
(
"sandbox",
summarize_sandbox_policy(config.permissions.sandbox_policy.get()),
summarize_sandbox_policy(config.permissions.sandbox_policy.get(), false),
),
];
if config.model_provider.wire_api == WireApi::Responses {
@@ -1,7 +1,10 @@
use codex_core::protocol::NetworkAccess;
use codex_core::protocol::SandboxPolicy;
pub fn summarize_sandbox_policy(sandbox_policy: &SandboxPolicy) -> String {
pub fn summarize_sandbox_policy(
sandbox_policy: &SandboxPolicy,
ignore_writable_roots: bool,
) -> String {
match sandbox_policy {
SandboxPolicy::DangerFullAccess => "danger-full-access".to_string(),
SandboxPolicy::ReadOnly { .. } => "read-only".to_string(),
@@ -35,7 +38,9 @@ pub fn summarize_sandbox_policy(sandbox_policy: &SandboxPolicy) -> String {
.map(|p| p.to_string_lossy().to_string()),
);
summary.push_str(&format!(" [{}]", writable_entries.join(", ")));
if !ignore_writable_roots {
summary.push_str(&format!(" [{}]", writable_entries.join(", ")));
}
if *network_access {
summary.push_str(" (network access enabled)");
}
@@ -52,17 +57,23 @@ mod tests {
#[test]
fn summarizes_external_sandbox_without_network_access_suffix() {
let summary = summarize_sandbox_policy(&SandboxPolicy::ExternalSandbox {
network_access: NetworkAccess::Restricted,
});
let summary = summarize_sandbox_policy(
&SandboxPolicy::ExternalSandbox {
network_access: NetworkAccess::Restricted,
},
false,
);
assert_eq!(summary, "external-sandbox");
}
#[test]
fn summarizes_external_sandbox_with_enabled_network() {
let summary = summarize_sandbox_policy(&SandboxPolicy::ExternalSandbox {
network_access: NetworkAccess::Enabled,
});
let summary = summarize_sandbox_policy(
&SandboxPolicy::ExternalSandbox {
network_access: NetworkAccess::Enabled,
},
false,
);
assert_eq!(summary, "external-sandbox (network access enabled)");
}
@@ -70,13 +81,16 @@ mod tests {
fn workspace_write_summary_still_includes_network_access() {
let root = if cfg!(windows) { "C:\\repo" } else { "/repo" };
let writable_root = AbsolutePathBuf::try_from(root).unwrap();
let summary = summarize_sandbox_policy(&SandboxPolicy::WorkspaceWrite {
writable_roots: vec![writable_root.clone()],
read_only_access: Default::default(),
network_access: true,
exclude_tmpdir_env_var: true,
exclude_slash_tmp: true,
});
let summary = summarize_sandbox_policy(
&SandboxPolicy::WorkspaceWrite {
writable_roots: vec![writable_root.clone()],
read_only_access: Default::default(),
network_access: true,
exclude_tmpdir_env_var: true,
exclude_slash_tmp: true,
},
false,
);
assert_eq!(
summary,
format!(