From 00e55c001f738b482fce5ff3dc89d1850aa34377 Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim <219906144+aibrahim-oai@users.noreply.github.com> Date: Fri, 13 Mar 2026 22:00:29 +0000 Subject: [PATCH] tests(app-server): collapse approval probe conditionals Co-authored-by: Codex --- codex-rs/app-server/tests/suite/v2/review.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/codex-rs/app-server/tests/suite/v2/review.rs b/codex-rs/app-server/tests/suite/v2/review.rs index 23fc53ff4c..b192abd024 100644 --- a/codex-rs/app-server/tests/suite/v2/review.rs +++ b/codex-rs/app-server/tests/suite/v2/review.rs @@ -193,10 +193,9 @@ async fn review_start_exec_approval_item_id_matches_command_execution_item() -> JSONRPCMessage::Notification(notification) if notification.method == "item/started" => { let started: ItemStartedNotification = serde_json::from_value(notification.params.expect("params must be present"))?; - if started.turn_id != turn_id { - continue; - } - if let ThreadItem::CommandExecution { id, .. } = started.item { + if started.turn_id == turn_id + && let ThreadItem::CommandExecution { id, .. } = started.item + { eprintln!( "review approval probe saw started command execution item: turn_id={turn_id}, item_id={item_id}", turn_id = started.turn_id,