mirror of
https://github.com/openai/codex.git
synced 2026-11-20 22:40:37 +00:00
codex: address PR review feedback (#28037)
This commit is contained in:
@@ -103,6 +103,13 @@ pub struct UnifiedExecRuntime<'a> {
|
|||||||
shell_mode: UnifiedExecShellMode,
|
shell_mode: UnifiedExecShellMode,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Lifecycle callback surface that lets unified exec mirror its generic spawn
|
||||||
|
/// lifecycle into a resolved plugin-script execution.
|
||||||
|
///
|
||||||
|
/// Implementations must preserve the caller-provided callback order: unified
|
||||||
|
/// exec invokes the generic `SpawnLifecycle` first, then forwards the matching
|
||||||
|
/// plugin callback. Terminal callbacks may be repeated by cleanup paths, so
|
||||||
|
/// implementations must keep cancellation and finish handling idempotent.
|
||||||
trait PluginScriptLifecycle: Send + Sync {
|
trait PluginScriptLifecycle: Send + Sync {
|
||||||
fn mark_started(&self);
|
fn mark_started(&self);
|
||||||
fn mark_cancelled(&self);
|
fn mark_cancelled(&self);
|
||||||
@@ -935,7 +942,7 @@ mod tests {
|
|||||||
proposed_execpolicy_amendment: None,
|
proposed_execpolicy_amendment: None,
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
request.environment = Arc::new(
|
request.turn_environment.environment = Arc::new(
|
||||||
Environment::create_for_tests(Some("ws://127.0.0.1:1/remote-exec-server".to_string()))
|
Environment::create_for_tests(Some("ws://127.0.0.1:1/remote-exec-server".to_string()))
|
||||||
.expect("remote environment"),
|
.expect("remote environment"),
|
||||||
);
|
);
|
||||||
|
|||||||
Reference in New Issue
Block a user