deploy-metrics failed on the metrics host with
This account is currently not available.
which is /usr/sbin/nologin refusing 'ssh gitea_ci@host <command>' after
the key has already authenticated.
The --shell /usr/sbin/nologin came in with the rest of the provisioning
block copied from lair/mail. It had never surfaced because gitea_ci
already existed with /bin/bash on every host touched so far -- bob,
benjy, oolon, slartibartfast all have bash. The metrics host is the
first account this script actually created, so it is the first to have
the bug.
Creates with /bin/bash and repairs an existing nologin account, since
otherwise a re-run leaves the host permanently undeployable. Applied to
all three roles, not just the one that failed.
Note lair/mail carries the same line and would hit this on any genuinely
new host.