activity summary should count private-repo work, not omit it #7
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
/v1/activity/summarypassesinclude_private: false, so the summary cards only ever count public activity. The contribution graph directly above them passesinclude_private: true. The two views therefore disagree, with nothing on the page explaining why:Proposal
Alongside the named per-repo rows, emit at most one row per period aggregating that period's private-repo activity:
private = true,sourceandreponull.RepoPeriodCount.source/.repobecome nullable to carry it.The card should count it towards the period's changes but never towards its repository count — the lump covers an unknown number of repos — and render it last, unlinked and without a language bar. A language mix on the aggregate would narrow it back down to the repo it is meant to be hiding.
Granularity
Per period only, not per
(period, source). The per-period total is already derivable from/v1/activity/daily, which counts private activity, so publishing it adds nothing that isn't already on the contribution graph. A per-forge split would be genuinely new information.The
?source=filter is the exception: it narrows the aggregate, which makes per-forge counts recoverable by diffing two requests. Accepted knowingly — a summary that contradicts the filter it was handed is the worse failure.Note on
include_privateThe parameter keeps its meaning. With it set, the named branch takes everything and the aggregate is empty, so a future authenticated view sees repos rather than a lump.