Commit Graph

397 Commits

Author SHA1 Message Date
Jeremiah Russell
cd907882ae 🧪 test(message-list): add edge-case tests (empty first page, no next_page_token despite pages > 1) 2025-10-20 08:16:45 +01:00
Jeremiah Russell
34125e7d5c 🧪 test(message-list): add test-only GmailService mock and end-to-end pagination test (no network) 2025-10-20 08:16:45 +01:00
Jeremiah Russell
4c5378c90b ♻️ refactor(message-list): introduce GmailService abstraction and refactor to use it; fix borrows and lifetimes 2025-10-20 08:16:45 +01:00
Jeremiah Russell
161710e1f9 ♻️ refactor(message-list): extract helper to append messages from ListMessagesResponse and add unit test 2025-10-20 08:16:45 +01:00
Jeremiah Russell
d0b1391738 fix(message-list): improve idioms (avoid redundant clone, extend labels, safer message extraction) 2025-10-20 08:16:45 +01:00
Jeremiah Russell
1fd9c29ead 🧹 chore(message-list): enable missing_docs lint for module 2025-10-20 08:16:45 +01:00
Jeremiah Russell
b878ff6152 🎨 style(message-list): apply rustfmt to satisfy CI fmt check 2025-10-20 08:16:45 +01:00
Jeremiah Russell
0042ba271f fix(clippy): move tests module to file end to satisfy items_after_test_module lint 2025-10-20 08:16:45 +01:00
Jeremiah Russell
e48535c623 🎨 style: format codebase with cargo fmt 2025-10-20 08:16:45 +01:00
Jeremiah Russell
3d16bd22d1 🧪 test(message-list): add unit tests for trait behavior using mock implementation 2025-10-20 08:16:45 +01:00
Jeremiah Russell
501d8a5830 📝 docs(message-list): document trait and public methods with examples and error semantics 2025-10-20 08:16:45 +01:00
Jeremiah Russell
257caf55ab 📝 docs(message-list): add module-level rustdoc with overview and usage example 2025-10-20 08:16:45 +01:00
Jeremiah Russell
06d63fbd03 🎨 style(rule_processor): apply rustfmt and resolve clippy warnings 2025-10-19 09:51:56 +01:00
Jeremiah Russell
f16eb0a768 🧪 test(rule_processor): add passing rustdoc examples and validate with doc tests 2025-10-19 09:51:56 +01:00
Jeremiah Russell
1012047d89 🧪 test(rule_processor): add comprehensive unit tests for orchestration and state setters 2025-10-19 09:51:56 +01:00
Jeremiah Russell
992414e0b9 ♻️ refactor(rule_processor): extract process_label and add internal ops trait for unit testing 2025-10-19 09:51:56 +01:00
Jeremiah Russell
d91b3e3b92 ♻️ refactor(rule_processor): add TRASH_LABEL, correct Gmail scopes, early returns, and improve idioms 2025-10-19 09:51:56 +01:00
Jeremiah Russell
ea948eda27 📝 docs(rule_processor): add module and method docs with safety notes and doctest examples 2025-10-19 09:51:56 +01:00
Jeremiah Russell
2b420e53cb style: format code with rustfmt 2025-10-19 08:52:23 +01:00
Jeremiah Russell
8f908df8f3 refactor(rules): apply idiomatic patterns and resolve clippy warnings
- Change add_rule parameter from Option<&String> to Option<&str> for better ergonomics
- Use iterator methods (flat_map, any) instead of manual loops and collections
- Collapse nested if conditions using let-else patterns
- Use format string interpolation instead of separate arguments
- Avoid unnecessary String allocations in label comparisons
- Update CLI code to use as_deref() for Option<String> to Option<&str> conversion
- Update all documentation examples and tests to match new API
- All functionality preserved; API is more idiomatic and efficient
2025-10-19 08:52:23 +01:00
Jeremiah Russell
a43eb9e4a2 refactor(rules): replace unwrap() with explicit error handling and propagate errors safely
- Replace Option::unwrap() with pattern matching in add_rule label check
- Handle home directory resolution failures with proper Error types
- Add directory creation in save() to ensure parent directories exist
- Replace chrono unwraps with ? operator for date calculations
- Use unwrap_or with sensible defaults for parsing edge cases
- Keep unwrap in test code where immediate failure is desired
- All existing functionality preserved; no API changes
2025-10-19 08:52:23 +01:00
Jeremiah Russell
74512bdea3 test(rules): add unit tests covering all public methods and edge cases
- Add comprehensive test coverage for all Rules public methods
- Test both success and error paths with proper assertions
- Add PartialEq derive to EolAction to enable comparisons in tests
- Include edge cases like duplicate labels and nonexistent IDs
- Mark file system integration tests as ignore to avoid interference
2025-10-19 08:52:23 +01:00
Jeremiah Russell
222bd87415 docs(rules): add comprehensive documentation and usage examples for Rules and its methods 2025-10-19 08:52:23 +01:00
Jeremiah Russell
724c930234 docs(eol_rule): add comprehensive documentation and examples 2025-10-19 08:52:23 +01:00
Jeremiah Russell
8fbe12346f 🐛 fix(retention): fix debug string formatting in retention struct
- change format macro to resolve cargo clippy warning
2025-10-19 07:54:12 +01:00
Jeremiah Russell
051507856a feat(retention): enhance message age with parsing and validation
- add `TryFrom<&str>` implementation for `MessageAge`
  - allows creating `MessageAge` from string slices
  - returns `Error` for invalid formats
- improve `MessageAge::new` to return a `Result`
  - changes error type to `Error` enum
- add `Error::InvalidMessageAge` for specific message age errors
- mark `MessageAge::parse` and other methods as `must_use`
- use byte string literals for character matching in `parse`
- update error messages to include the invalid input value
- add `#[derive(Hash)]` to `MessageAge`
2025-10-19 07:54:12 +01:00
Jeremiah Russell
5c2124ead4 🐛 fix(cli): correct error mapping in add_cli
- fix error mapping for message age creation
- use direct error propagation instead of config error mapping
2025-10-19 07:54:12 +01:00
Jeremiah Russell
1448c791d9 feat(retention): implement retention policy configuration
- define struct for retention policy with message age and label generation
- add methods to create, access, and modify retention policies
- implement default values, cloning, equality, and debug formatting
2025-10-19 07:54:12 +01:00
Jeremiah Russell
32db9cb51a feat(error): add invalid message age error
- add `InvalidMessageAge` error variant to the `Error` enum
- include a message parameter to provide details about the invalid age
2025-10-19 07:54:12 +01:00
Jeremiah Russell
c40e4dfa86 feat(retention): introduce message age specification
- introduces `MessageAge` enum to represent retention periods
- supports days, weeks, months, and years
- adds parsing and formatting for `MessageAge` instances
- includes label generation for categorization
2025-10-19 07:54:12 +01:00
Jeremiah Russell
dd16da8740 🐛 fix(rules): handle message age creation error
- handle the error when creating MessageAge and return a ConfigError::Message
2025-10-19 07:54:12 +01:00
Jeremiah Russell
722d57086e feat(retention): enhance retention policy configuration
- introduce `Retention` struct for managing message retention policies
- add `new` constructor with age and generate_label options
- implement getter methods for age and generate_label
- add `set_generate_label` to control label generation dynamically
- provide examples and usage documentation
- include comprehensive unit tests

📝 docs(retention): document retention policy configuration

- provide detailed documentation for `Retention` struct
- include usage examples for creating and configuring retention policies
- explain the purpose of the `age` and `generate_label` fields
- describe the behavior of `set_generate_label` method
2025-10-19 07:54:12 +01:00
Jeremiah Russell
75dc301fe3 📝 docs(lib): update lib.md path
- fix the path of lib.md to be under docs/lib
2025-10-18 08:11:30 +01:00
Jeremiah Russell
754e5229ae ♻️ refactor(cli): extract action execution into a function
- move action execution logic into `execute_action` function
- improve code readability and reduce duplication
2025-10-16 17:28:55 +01:00
Jeremiah Russell
9116e7c406 ♻️ refactor(cli): rename get_config to get_rules
- rename function to better reflect its purpose
2025-10-16 17:28:55 +01:00
Jeremiah Russell
f1e873009b ♻️ refactor(cli): extract rule execution to separate function
- move rule execution logic to run_rules function
- this improves code organization and testability
2025-10-16 17:28:55 +01:00
Jeremiah Russell
0136d7da09 feat(cli): add default subcommand for rule execution
- Add a default subcommand that executes rules based on configuration.
- Load rules and configuration to determine execution behavior.
- Implement dry run functionality to prevent unintended actions.
2025-10-16 17:28:55 +01:00
Jeremiah Russell
486bcb1934 ♻️ refactor(config): improve ConfigRoot to handle different root types
- change ConfigRoot to use RootBase enum for different root types (Crate, Home, Root, None)
- add full_path method to resolve the full path based on RootBase and path
- update tests to use full_path to string conversion for assertions
2025-10-16 15:37:01 +01:00
Jeremiah Russell
73e9eed539 🐛 fix(gmail): fix token persistence path
- Use the persist_path from the config instead of a hardcoded path to ensure tokens are persisted to the correct location
2025-10-16 15:37:01 +01:00
Jeremiah Russell
368e78b1cc feat(config): implement config builder pattern for ClientConfig
- introduce ConfigBuilder struct for constructing ClientConfig instances
- add methods to ConfigBuilder for setting various configuration parameters
- implement a build method to create the ClientConfig instance
- add a default implementation for ConfigBuilder
- enhance ClientConfig with persist_path for token persistence
- update ClientConfig::new_from_configuration to use config_root.full_path()
- add ClientConfig::persist_path() to report the full path to the file to persist tokens
2025-10-16 15:37:01 +01:00
Jeremiah Russell
556d7bd598 ♻️ refactor(utils): improve config directory creation
- simplify directory creation logic
- handle existing directory case more efficiently
2025-10-16 11:21:40 +01:00
Jeremiah Russell
44b98d0657 feat(cli): load configurations from toml file
- load configurations from `cull-gmail.toml`
- set default value for rules in config
2025-10-16 11:21:40 +01:00
Jeremiah Russell
1ae34efb93 🐛 fix(config): resolve credential file path issue
- fix the problem of reading credential file in the production environment
- use config_root to find credential file
2025-10-16 11:21:40 +01:00
Jeremiah Russell
b17e72e6f3 feat(client_config): add config root parsing with regex
- introduce regex-based parsing for config root strings
- support 'h', 'r', and 'c' prefixes for home, root, and crate paths
- add tests for parsing different config root types
2025-10-16 11:21:40 +01:00
Jeremiah Russell
8ab89cdb0a feat(utils): add test utils module
- add test_utils module to provide common utilities for tests
- add get_test_logger function for initializing test logger
2025-10-16 11:21:40 +01:00
Jeremiah Russell
66b7c820d7 ♻️ refactor(cli): use ClientConfig struct for gmail client
- use ClientConfig struct instead of credential string
- load config from file and env vars
- simplify config loading and client creation
2025-10-16 11:21:40 +01:00
Jeremiah Russell
591e528291 ♻️ refactor(gmail): use client config for gmail client
- Replace credential file path with client config struct
- Simplify client initialization and authentication using yup-oauth2
2025-10-16 11:21:40 +01:00
Jeremiah Russell
3255f24c3a feat(config): add ConfigRoot enum for flexible path handling
- introduce ConfigRoot enum to represent different configuration file locations
- implement Display trait for ConfigRoot to provide string representation
- add parse method to determine ConfigRoot type based on prefix (h, r, c)
2025-10-16 11:21:40 +01:00
Jeremiah Russell
440144eee5 feat(core): add client config
- add client_config module for managing client configurations
- expose ClientConfig struct for external usage
2025-10-16 11:21:40 +01:00
Jeremiah Russell
dd1fe356a2 feat(config): introduce client configuration
- adds `ClientConfig` struct for managing Gmail client settings
- supports loading credentials from environment variables or a JSON file
- provides methods to access the application secret and configuration root
2025-10-16 11:21:40 +01:00