♻️ refactor(message): improve subject logging with early returns
- use early returns and `else` blocks for better readability and reduced nesting - add a log message to indicate emails with no subject
This commit is contained in:
committed by
Jeremiah Russell
parent
7ba4b09fc2
commit
cbe61ab2f3
@@ -163,9 +163,12 @@ impl Message {
|
|||||||
}
|
}
|
||||||
|
|
||||||
async fn log_message_subjects(&self, list: &ListMessagesResponse) -> Result<(), Error> {
|
async fn log_message_subjects(&self, list: &ListMessagesResponse) -> Result<(), Error> {
|
||||||
if let Some(messages) = &list.messages {
|
let Some(messages) = &list.messages else {
|
||||||
|
return Ok(());
|
||||||
|
};
|
||||||
|
|
||||||
for message in messages {
|
for message in messages {
|
||||||
if let Some(id) = &message.id {
|
let Some(id) = &message.id else { continue };
|
||||||
log::trace!("{id}");
|
log::trace!("{id}");
|
||||||
let (_res, m) = self
|
let (_res, m) = self
|
||||||
.hub
|
.hub
|
||||||
@@ -179,8 +182,11 @@ impl Message {
|
|||||||
.map_err(Box::new)?;
|
.map_err(Box::new)?;
|
||||||
|
|
||||||
let mut subject = String::new();
|
let mut subject = String::new();
|
||||||
if let Some(payload) = m.payload {
|
let Some(payload) = m.payload else { continue };
|
||||||
if let Some(headers) = payload.headers {
|
let Some(headers) = payload.headers else {
|
||||||
|
continue;
|
||||||
|
};
|
||||||
|
|
||||||
for header in headers {
|
for header in headers {
|
||||||
if header.name.is_some()
|
if header.name.is_some()
|
||||||
&& header.name.unwrap() == "Subject"
|
&& header.name.unwrap() == "Subject"
|
||||||
@@ -192,13 +198,13 @@ impl Message {
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
|
if subject.is_empty() {
|
||||||
|
log::info!("***Email with no subject***");
|
||||||
|
} else {
|
||||||
log::info!("{subject:?}");
|
log::info!("{subject:?}");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user