grenade/cull-gmail
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

♻️ refactor(message_list): remove client parameter from add_labels

Browse Source 
- remove client parameter from `add_labels` function to use self
- simplify the function signature and improve code readability
This commit is contained in:
Jeremiah Russell
2025-10-13 15:52:20 +01:00
committed by Jeremiah Russell
parent 0ebfde4912
commit 9625e64979
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/message_list.rs
View File

@@ -20,7 +20,7 @@ pub(crate) trait MessageList {
fn messages(&self) -> &Vec<MessageSummary>; fn messages(&self) -> &Vec<MessageSummary>;
fn set_query(&mut self, query: &str); fn set_query(&mut self, query: &str);
fn add_labels_ids(&mut self, label_ids: &[String]); fn add_labels_ids(&mut self, label_ids: &[String]);
async fn add_labels(&mut self, client: &GmailClient, labels: &[String]) -> Result<()>; async fn add_labels(&mut self, labels: &[String]) -> Result<()>;
fn max_results(&self) -> u32; fn max_results(&self) -> u32;
fn set_max_results(&mut self, value: u32); fn set_max_results(&mut self, value: u32);
} }
@@ -48,11 +48,11 @@ impl MessageList for GmailClient {
} }
/// Add label to the labels collection /// Add label to the labels collection
async fn add_labels(&mut self, client: &GmailClient, labels: &[String]) -> Result<()> { async fn add_labels(&mut self, labels: &[String]) -> Result<()> {
log::debug!("labels from command line: {labels:?}"); log::debug!("labels from command line: {labels:?}");
let mut label_ids = Vec::new(); let mut label_ids = Vec::new();
for label in labels { for label in labels {
if let Some(id) = client.get_label_id(label) { if let Some(id) = self.get_label_id(label) {
label_ids.push(id) label_ids.push(id)
} }
} }