From 55b1d9a25d185c2c7a28d6ba6e2bf1b059945c79 Mon Sep 17 00:00:00 2001 From: Jeremiah Russell Date: Wed, 15 Oct 2025 11:21:08 +0100 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20refactor(eol=5Frule):=20im?= =?UTF-8?q?prove=20labels=20handling?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - use `cloned()` instead of `map(|i| i.to_string())` for better efficiency --- src/rules/eol_rule.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rules/eol_rule.rs b/src/rules/eol_rule.rs index f7f7cbb..b600f38 100644 --- a/src/rules/eol_rule.rs +++ b/src/rules/eol_rule.rs @@ -26,7 +26,7 @@ impl fmt::Display for EolRule { self.id, self.labels .iter() - .map(|i| i.to_string()) + .cloned() .collect::>() .join(", ") ) @@ -73,7 +73,7 @@ impl EolRule { /// List the labels in the rules pub fn labels(&self) -> Vec { - self.labels.iter().map(|i| i.to_string()).collect() + self.labels.iter().cloned().collect() } pub(crate) fn set_action(&mut self, value: &EolAction) -> &mut Self {