grenade/cull-gmail
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

♻️ refactor(message_list): rename run to get_messages

Browse Source 
- rename run to get_messages for better clarity
- remove async from add_labels trait and implementation
This commit is contained in:
Jeremiah Russell
2025-10-14 07:26:58 +01:00
committed by Jeremiah Russell
parent 7e1d07b3ab
commit 50a3b394de
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/message_list.rs
View File

@@ -17,7 +17,7 @@ pub trait MessageList {
next_page_token: Option<String>, next_page_token: Option<String>,
) -> impl std::future::Future<Output = Result<ListMessagesResponse>> + Send; ) -> impl std::future::Future<Output = Result<ListMessagesResponse>> + Send;
/// Run something /// Run something
fn run(&mut self, pages: u32) -> impl std::future::Future<Output = Result<()>> + Send; fn get_messages(&mut self, pages: u32) -> impl std::future::Future<Output = Result<()>> + Send;
/// Return the gmail hub /// Return the gmail hub
fn hub(&self) -> Gmail<HttpsConnector<HttpConnector>>; fn hub(&self) -> Gmail<HttpsConnector<HttpConnector>>;
/// Return the list of label_ids /// Return the list of label_ids
@@ -31,10 +31,7 @@ pub trait MessageList {
/// Add label ids to the list of labels for the message list /// Add label ids to the list of labels for the message list
fn add_labels_ids(&mut self, label_ids: &[String]); fn add_labels_ids(&mut self, label_ids: &[String]);
/// Add labels to the list of labels for the message list /// Add labels to the list of labels for the message list
fn add_labels( fn add_labels(&mut self, labels: &[String]) -> Result<()>;
&mut self,
labels: &[String],
) -> impl std::future::Future<Output = Result<()>> + Send;
/// Report the max results value set /// Report the max results value set
fn max_results(&self) -> u32; fn max_results(&self) -> u32;
/// Set the max_results value /// Set the max_results value
@@ -64,7 +61,7 @@ impl MessageList for GmailClient {
} }
/// Add label to the labels collection /// Add label to the labels collection
async fn add_labels(&mut self, labels: &[String]) -> Result<()> { fn add_labels(&mut self, labels: &[String]) -> Result<()> {
log::debug!("labels from command line: {labels:?}"); log::debug!("labels from command line: {labels:?}");
let mut label_ids = Vec::new(); let mut label_ids = Vec::new();
for label in labels { for label in labels {
@@ -115,7 +112,7 @@ impl MessageList for GmailClient {
} }
/// Run the Gmail api as configured /// Run the Gmail api as configured
async fn run(&mut self, pages: u32) -> Result<()> { async fn get_messages(&mut self, pages: u32) -> Result<()> {
let list = self.messages_list(None).await?; let list = self.messages_list(None).await?;
match pages { match pages {
1 => {} 1 => {}